Preloading xwidget.el on xwidget builds?

Preloading xwidget.el on xwidget builds?

[Po Lu]

xwidget.el defines various parts of the internal xwidget machinery, such
as the `xwidget-event' handler, and pieces of Lisp code that keep
xwidget display working correctly.

Using xwidget-related C functions without xwidget.el loaded can lead to
crashes and display problems, so I propose to preload that file on
xwidget builds.

Thanks.

Re: Preloading xwidget.el on xwidget builds?

[Stefan Monnier]

> xwidget.el defines various parts of the internal xwidget machinery, such
> as the `xwidget-event' handler, and pieces of Lisp code that keep
> xwidget display working correctly.
>
> Using xwidget-related C functions without xwidget.el loaded can lead to
> crashes and display problems, so I propose to preload that file on
> xwidget builds.

IME files that are preloaded in some config and not on others are
a source of trouble.  I'd rather we fix this some other way, e.g. by
autoloading those function.


        Stefan

Re: Preloading xwidget.el on xwidget builds?

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> xwidget.el defines various parts of the internal xwidget machinery, such
>> as the `xwidget-event' handler, and pieces of Lisp code that keep
>> xwidget display working correctly.
>>
>> Using xwidget-related C functions without xwidget.el loaded can lead to
>> crashes and display problems, so I propose to preload that file on
>> xwidget builds.
>
> IME files that are preloaded in some config and not on others are
> a source of trouble.  I'd rather we fix this some other way, e.g. by
> autoloading those function.

How would autoloading solve that problem though: `make-xwidget' and such
are defined in C code, but their display depends on xwidget.el to work
correctly.

Thanks.

Re: Preloading xwidget.el on xwidget builds?

[Stefan Monnier]

>>> xwidget.el defines various parts of the internal xwidget machinery, such
>>> as the `xwidget-event' handler, and pieces of Lisp code that keep
>>> xwidget display working correctly.
>>>
>>> Using xwidget-related C functions without xwidget.el loaded can lead to
>>> crashes and display problems, so I propose to preload that file on
>>> xwidget builds.
>>
>> IME files that are preloaded in some config and not on others are
>> a source of trouble.  I'd rather we fix this some other way, e.g. by
>> autoloading those function.
>
> How would autoloading solve that problem though: `make-xwidget' and such
> are defined in C code, but their display depends on xwidget.el to work
> correctly.

Depends on details I don't know, but presumably `make-xwidget` could
explicitly require/load `xwidget.el`.  Or the display could end up
loading `xwidget.el` when it calls a function defined there in (by
marking those functions as autoloaded).


        Stefan

Re: Preloading xwidget.el on xwidget builds?

[Stefan Monnier]

> Depends on details I don't know, but presumably `make-xwidget` could
> explicitly require/load `xwidget.el`.  Or the display could end up
> loading `xwidget.el` when it calls a function defined there in (by
> marking those functions as autoloaded).

Or we could move `make-xwidget` to `xwidget.el` and rename the
C function to something like `internal--make-widget`.


        Stefan

Re: Preloading xwidget.el on xwidget builds?

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Or we could move `make-xwidget` to `xwidget.el` and rename the
> C function to something like `internal--make-widget`.

Hmm, good idea.

How can I make autoloads conditional on a build configuration though?  A
very large amount of code uses (fboundp 'make-xwidget) to detect xwidget
support, and breaking that would be very inconvenient.

Thanks.

Re: Preloading xwidget.el on xwidget builds?

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

>> Or we could move `make-xwidget` to `xwidget.el` and rename the
>> C function to something like `internal--make-widget`.
>
> Hmm, good idea.
>
> How can I make autoloads conditional on a build configuration though?  A
> very large amount of code uses (fboundp 'make-xwidget) to detect xwidget
> support, and breaking that would be very inconvenient.

We've been trying to move to a different architecture for detecting
whether Emacs has been built with, and currently has access to, external
libraries -- `*-available-p'.  It'd be nice if xwidget had that
function, too.

But as you point out, people test for `make-xwidget' today, so we can't
really move it to Lisp, I think.  So I think Stefan's first
suggestion -- make `make-xwidget' require widget.el -- is the way to go.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Preloading xwidget.el on xwidget builds?

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> We've been trying to move to a different architecture for detecting
> whether Emacs has been built with, and currently has access to, external
> libraries -- `*-available-p'.  It'd be nice if xwidget had that
> function, too.

The problem is `xwidget' isn't really a library, it's a feature that
makes use of many different external libraries.  Ideally, people would
test for the named feature `xwidget-internal', but the amount of people
who refrained from reading the first paragraph of the xwidget node in
the Lisp reference manual is astonishing.

> suggestion -- make `make-xwidget' require widget.el -- is the way to go.

Is calling require okay from C code?  If so, that's what I'll do.

Thanks.

Re: Preloading xwidget.el on xwidget builds?

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

>> We've been trying to move to a different architecture for detecting
>> whether Emacs has been built with, and currently has access to, external
>> libraries -- `*-available-p'.  It'd be nice if xwidget had that
>> function, too.
>
> The problem is `xwidget' isn't really a library, it's a feature that
> makes use of many different external libraries.

Sorry, I mean "optionally build features".

> Ideally, people would test for the named feature `xwidget-internal',
> but the amount of people who refrained from reading the first
> paragraph of the xwidget node in the Lisp reference manual is
> astonishing.

The first rule of programming is that nobody reads the manual.

(xwidget-available-p 'webkit) could say whether webkit was available,
etc.

>> suggestion -- make `make-xwidget' require widget.el -- is the way to go.
>
> Is calling require okay from C code?  If so, that's what I'll do.

It's unusual, but to work around unfortunate dependencies like this, it
should be OK.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Preloading xwidget.el on xwidget builds?

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Thu, 16 Dec 2021 08:46:38 +0800
> 
> xwidget.el defines various parts of the internal xwidget machinery, such
> as the `xwidget-event' handler, and pieces of Lisp code that keep
> xwidget display working correctly.
> 
> Using xwidget-related C functions without xwidget.el loaded can lead to
> crashes and display problems, so I propose to preload that file on
> xwidget builds.

I don't think I understand the problem you are describing.  Can you
please describe the situations in which the xwidget-related C
functions would be invoked without xwidget.el being loaded?

Re: Preloading xwidget.el on xwidget builds?

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 16 Dec 2021 12:41:43 +0800
> 
> > IME files that are preloaded in some config and not on others are
> > a source of trouble.  I'd rather we fix this some other way, e.g. by
> > autoloading those function.
> 
> How would autoloading solve that problem though: `make-xwidget' and such
> are defined in C code, but their display depends on xwidget.el to work
> correctly.

Which code could call make-xwidget when xwidget.el is not loaded?

Re: Preloading xwidget.el on xwidget builds?

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> I don't think I understand the problem you are describing.  Can you
> please describe the situations in which the xwidget-related C
> functions would be invoked without xwidget.el being loaded?

(This has been fixed now: see the other replies to this thread.)

For instance, `make-xwidget' can be called to create xwidgets, and they
can be displayed on screen, all without xwidget.el being loaded.

A package that uses xwidgets to preview LaTeX does this, and that
package brought this problem to my attention.

Thanks.

Re: Preloading xwidget.el on xwidget builds?

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Which code could call make-xwidget when xwidget.el is not loaded?

Any Lisp code was able to do that.