Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol

Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol

[Robert Pluim]

>>>>> On Wed,  9 Feb 2022 03:14:53 -0500 (EST), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

    Po> branch: master
    Po> commit 7f9335f91d3e0ecdff9c3adb93aad08454002035
    Po> Author: Po Lu <luangruo@yahoo.com>
    Po> Commit: Po Lu <luangruo@yahoo.com>

    Po>     Implement _NET_WM_USER_TIME protocol
    
    Po>     * src/xterm.c (x_display_set_last_user_time): Set user time on
    Po>     the active window.
    Po>     (handle_one_xevent): Only set user time when the user actually
    Po>     interacted with Emacs.
    Po>     (x_make_frame_visible): Set user time if non-zero.
    Po>     (x_term_init): Intern `_NET_WM_USER_TIME'.
    Po>     * src/xterm.h (struct x_display_info): New field
    Po>     `Xatom_net_wm_user_time'.
    Po>     (x_display_set_last_user_time): Implement in xterm.c instead.
    Po> ---
    Po>  src/xterm.c | 101 ++++++++++++++++++++++++++++++++++++++----------------------
    Po>  src/xterm.h |  14 +++------
    Po>  2 files changed, 69 insertions(+), 46 deletions(-)

  CC       xterm.o
xterm.c: In function ‘handle_one_xevent’:
xterm.c:11762:6: error: a label can only be part of a statement and a declaration is not a statement
11762 |      XKeyPressedEvent xkey;
      |      ^~~~~~~~~~~~~~~~
make[1]: *** [Makefile:414: xterm.o] Error 1
make[1]: Leaving directory '/home/rpluim/repos/emacs/src'
make: *** [Makefile:469: src] Error 2

Are you compiling emacs with a c++ compiler?

Robert
-- 

Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol

[Andreas Schwab]

On Feb 09 2022, Po Lu via Mailing list for Emacs changes wrote:

> +void
> +x_display_set_last_user_time (struct x_display_info *dpyinfo, Time time)
> +{
> +  struct frame *focus_frame = dpyinfo->x_focus_frame;
> +
> +#ifdef ENABLE_CHECKING
> +  eassert (t <= X_ULONG_MAX);
> +#endif

../../emacs/src/xterm.c: In function ‘x_display_set_last_user_time’:
../../emacs/src/xterm.c:2228:12: error: ‘t’ undeclared (first use in this function); did you mean ‘it’?
   eassert (t <= X_ULONG_MAX);
            ^

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol

[Po Lu]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed,  9 Feb 2022 03:14:53 -0500 (EST), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:
>
>     Po> branch: master
>     Po> commit 7f9335f91d3e0ecdff9c3adb93aad08454002035
>     Po> Author: Po Lu <luangruo@yahoo.com>
>     Po> Commit: Po Lu <luangruo@yahoo.com>
>
>     Po>     Implement _NET_WM_USER_TIME protocol
>     
>     Po>     * src/xterm.c (x_display_set_last_user_time): Set user time on
>     Po>     the active window.
>     Po>     (handle_one_xevent): Only set user time when the user actually
>     Po>     interacted with Emacs.
>     Po>     (x_make_frame_visible): Set user time if non-zero.
>     Po>     (x_term_init): Intern `_NET_WM_USER_TIME'.
>     Po>     * src/xterm.h (struct x_display_info): New field
>     Po>     `Xatom_net_wm_user_time'.
>     Po>     (x_display_set_last_user_time): Implement in xterm.c instead.
>     Po> ---
>     Po>  src/xterm.c | 101 ++++++++++++++++++++++++++++++++++++++----------------------
>     Po>  src/xterm.h |  14 +++------
>     Po>  2 files changed, 69 insertions(+), 46 deletions(-)
>
>   CC       xterm.o
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:11762:6: error: a label can only be part of a statement and a declaration is not a statement
> 11762 |      XKeyPressedEvent xkey;
>       |      ^~~~~~~~~~~~~~~~
> make[1]: *** [Makefile:414: xterm.o] Error 1
> make[1]: Leaving directory '/home/rpluim/repos/emacs/src'
> make: *** [Makefile:469: src] Error 2
>
> Are you compiling emacs with a c++ compiler?

No, and that can't work anyway.  (But I see the problem now, thanks.)