From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol Date: Thu, 10 Feb 2022 10:00:37 +0800 Message-ID: <87mtizzdiy.fsf@yahoo.com> References: <164439449311.24347.14340914112590544821@vcs2.savannah.gnu.org> <20220209081453.69C44C0DA3A@vcs2.savannah.gnu.org> <87zgn02h28.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 10 03:03:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHyns-0007t4-Mw for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Feb 2022 03:03:24 +0100 Original-Received: from localhost ([::1]:49638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHynr-00044w-Hl for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Feb 2022 21:03:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHymY-0003Ml-Aw for emacs-devel@gnu.org; Wed, 09 Feb 2022 21:02:03 -0500 Original-Received: from sonic303-20.consmr.mail.ne1.yahoo.com ([66.163.188.146]:40603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHymL-0001Zf-AH for emacs-devel@gnu.org; Wed, 09 Feb 2022 21:02:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644458447; bh=C8/slBxMRFG/aKlUbjW/cy53ZLBSn5EzG7plBPuDsZ8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=iQdKQtgo1NtJRbVSezXCcx8NrAajeQSDajOhh3zodA0AWNgs2gGMWir1XNIWNgbz3Z7yGlDqLlfPkE72GNN8H/6fjrRJ0FVbzu0B+0AXbX9ZawFyTFtFjVWcRkCKR9wW3DmP9FWmnsCWrujUDh4OG77l3amvj2iMN7VdXvWMgeeULcxeM+2/9DJpKwM5IKkYwgBPL4MVn5If8dt6wikW2OzvZyuFm22TPrwRBhu1GBUDnOeEphMyCU7a/VB7g1pESFtwz6zVBv5GnYwwOWkeRUHSUG7jQv/VJ94gX+vP/hxJAr7m7OoohHl968+YGSmFTAHBfy+BuFHFUhNW6KLCHQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644458447; bh=Hx30X4pOMDqGatf7Di4pt8o7/x7g/eJSxh3KZRDRRq7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fz0kUd75+skvzVqdeRojRjwecN6S3T7FhAoXNxxcJEXuO5St4+QQgpia375f7XUtL6qYuLx5GWDUxz+n/z5dFbxGnh4L/TyDej7UIA+lYI9LEf/ygsx7ax9GOA8T/1kmTPw/+hhI9oHl80aiIDtpEFvP9tw0rHJm9Q5RPD5VHpeYNmvuaJL8SqGh0ZiqGfqSMc/TSledMxjsoGTS4I3XJiNYwnvl1AKGsUIqd+eXN60e1eGG7XGFwH99WTWligwo0IsHMEr91umGBFm8yQanPxrvKngDb6wDSKjZFgl9qmMliuLVwH8CIe7BlD5GJ9frcnZ5htVz8LF/rTCeoCPCtg== X-YMail-OSG: RXytTNUVM1mW.SbINVYaV_Q8kKaYCTyDXbO9Wj9BNQxf9JdifNr7BAyd_vf6sMF BOIuSCTg_hf.n55rJBfTfN7aXlok0lYXVwEH0DMj3yPl3j6BfWOFjco.PxfCYrXIeGCrdMbM29cS 3.ZgIwz8rfT4mTkqgxzrVTsmjlON23UzfWclYv73GWkBKmBb4n5NntrrVTAA3hGfTtPqq_OQXIi7 U0AFEj1TG.dQVLxb_u3nfWgaGR311LikofLpWi_RjnbD32t6EHhNA2dEvDEmRp_FK8wPGg93nUNQ bl.05J3tLVqbJzIxOCBoAuf0D0_XhMyIBKThBQMNqgdSHwbyZElFWOD1ZYcmPnZBvXlILzqLTq2a joyycB8.90A1arfurUofLaDWVy.IWJ0t6IMgAHUZmlgr3JajdfQZEr0Km04IY6Zikajfw2XjmzPk YBikWF1SRamJUJkpvx21FWOO5p_rvBWoWvx7lWkRAZz_Tf7GP4ywWu4VLrxpTceRQ.XwZHYfXrdV DiFC8ZJV6TmetRHUhc3ONvu4CWQhqrcCxD1ih41qJcAIW9qXZFKIa6Kd9cb8SHWrE.VYIY9Wd51I OMRF4pLwH.vqQkU7ZEU3r5RR90ulfHeJjv4rvO_gcZdiAFOPq6xQmczQQurthM7n4wtFAv.WTHiS wBQrf0BlpUJxxWwTs.PwePjW8m_cYVYYzs0uEBUGRkUWqcj0L.I1PiddPwHohNx.yqtPNWXPPS2R vTTSgLJuis9CsyjMkVAQhjdkiIudMiOf4OVb96A6H.pyKS8MQ8jpZtU_JbEighCgByMoKmiTSjZd fsQZ4yO9MRGUtxPAHv25vf4dbHRIrAILiO8NrO2n2p X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Thu, 10 Feb 2022 02:00:47 +0000 Original-Received: by kubenode504.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 674f1c4869f644af25b7443ed0e6b98c; Thu, 10 Feb 2022 02:00:44 +0000 (UTC) In-Reply-To: <87zgn02h28.fsf@gmail.com> (Robert Pluim's message of "Wed, 09 Feb 2022 16:30:39 +0100") X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.146; envelope-from=luangruo@yahoo.com; helo=sonic303-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286119 Archived-At: Robert Pluim writes: >>>>>> On Wed, 9 Feb 2022 03:14:53 -0500 (EST), Po Lu via Mailing list for= Emacs changes said: > > Po> branch: master > Po> commit 7f9335f91d3e0ecdff9c3adb93aad08454002035 > Po> Author: Po Lu > Po> Commit: Po Lu > > Po> Implement _NET_WM_USER_TIME protocol >=20=20=20=20=20 > Po> * src/xterm.c (x_display_set_last_user_time): Set user time on > Po> the active window. > Po> (handle_one_xevent): Only set user time when the user actually > Po> interacted with Emacs. > Po> (x_make_frame_visible): Set user time if non-zero. > Po> (x_term_init): Intern `_NET_WM_USER_TIME'. > Po> * src/xterm.h (struct x_display_info): New field > Po> `Xatom_net_wm_user_time'. > Po> (x_display_set_last_user_time): Implement in xterm.c instead. > Po> --- > Po> src/xterm.c | 101 ++++++++++++++++++++++++++++++++++++++--------= -------------- > Po> src/xterm.h | 14 +++------ > Po> 2 files changed, 69 insertions(+), 46 deletions(-) > > CC xterm.o > xterm.c: In function =E2=80=98handle_one_xevent=E2=80=99: > xterm.c:11762:6: error: a label can only be part of a statement and a dec= laration is not a statement > 11762 | XKeyPressedEvent xkey; > | ^~~~~~~~~~~~~~~~ > make[1]: *** [Makefile:414: xterm.o] Error 1 > make[1]: Leaving directory '/home/rpluim/repos/emacs/src' > make: *** [Makefile:469: src] Error 2 > > Are you compiling emacs with a c++ compiler? No, and that can't work anyway. (But I see the problem now, thanks.)