Re: Requesting patch review

[Thien-Thi Nguyen <ttn@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

() Jackson Hamilton <jackson@jacksonrayhamilton.com>
() Sat, 7 Mar 2015 18:09:01 -0800

   +	* lisp/progmodes/js.el (js--proper-indentation): Add and use new
   +	custom option `js-dynamic-multi-line-declaration-indentation'.

I haven't looked at the code; this comment is on the ChangeLog,
which mentions ‘js-dynamic-multi-line-declaration-indentation’
(good), but in the wrong place (bad).  Better something like:

 * lisp/progmodes/js.el
 (js-dynamic-multi-line-declaration-indentation): New custom option.
 (js--proper-indentation): Use it.

That's admittedly more ugly, but maybe that could be a reason to
find a more concise name for the new custom option...

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]