From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: Requesting patch review Date: Sun, 08 Mar 2015 09:16:52 +0100 Message-ID: <8761ab7vkb.fsf@zigzag.favinet> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1425803022 3622 80.91.229.3 (8 Mar 2015 08:23:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Mar 2015 08:23:42 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 08 09:23:34 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YUWUl-0000xz-Fy for ged-emacs-devel@m.gmane.org; Sun, 08 Mar 2015 09:23:31 +0100 Original-Received: from localhost ([::1]:37807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUWUk-0008Tl-HB for ged-emacs-devel@m.gmane.org; Sun, 08 Mar 2015 04:23:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUWUU-0008TR-Kl for emacs-devel@gnu.org; Sun, 08 Mar 2015 04:23:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUWUR-0007IW-Em for emacs-devel@gnu.org; Sun, 08 Mar 2015 04:23:14 -0400 Original-Received: from mail.agora-net.com ([67.59.132.6]:47640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUWUR-0007IM-Bq for emacs-devel@gnu.org; Sun, 08 Mar 2015 04:23:11 -0400 Original-Received: from ttn by mail.agora-net.com with local (Exim 4.71) (envelope-from ) id 1YUWUQ-0006m3-9j for emacs-devel@gnu.org; Sun, 08 Mar 2015 04:23:10 -0400 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1YUWOS-0006Tm-JY for emacs-devel@gnu.org; Sun, 08 Mar 2015 09:17:00 +0100 Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Jackson Hamilton's message of "Sat, 7 Mar 2015 18:09:01 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ttn@gnuvola.org X-SA-Exim-Scanned: No (on mail.agora-net.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 67.59.132.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183726 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () Jackson Hamilton () Sat, 7 Mar 2015 18:09:01 -0800 + * lisp/progmodes/js.el (js--proper-indentation): Add and use new + custom option `js-dynamic-multi-line-declaration-indentation'. I haven't looked at the code; this comment is on the ChangeLog, which mentions =E2=80=98js-dynamic-multi-line-declaration-indentation=E2=80= =99 (good), but in the wrong place (bad). Better something like: * lisp/progmodes/js.el (js-dynamic-multi-line-declaration-indentation): New custom option. (js--proper-indentation): Use it. That's admittedly more ugly, but maybe that could be a reason to find a more concise name for the new custom option... =2D-=20 Thien-Thi Nguyen GPG key: 4C807502 (if you're human and you know it) read my lisp: (responsep (questions 'technical) (not (via 'mailing-list))) =3D> nil --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlT8BXcACgkQZwMiJEyAdQK+pgCg3dbFWeYLtm6VYknDWiv3Q8iI cH0An0pPwdu6AWwPudcKY+H1fxYJGAjD =0HZv -----END PGP SIGNATURE----- --=-=-=--