From: Dmitry Gutov <dgutov@yandex.ru>
To: Jackson Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Requesting patch review
Date: Tue, 10 Mar 2015 18:04:04 +0200 [thread overview]
Message-ID: <54FF15F4.1020902@yandex.ru> (raw)
In-Reply-To: <CAGiE8Az7v8g4aaemrS50uyY4pcwGsFEbcVSHxHew_ZyPpAZSuw@mail.gmail.com>
On 03/10/2015 03:34 AM, Jackson Hamilton wrote:
> (Dunno who has priority here, Emacs or the spec, but I'm fine with
> changing it.)
Up to you. Since Stefan made a point against being anal retentive, I'm
going to shut up. :)
>>maybe we should also extract the added lines into a utility function
>
> How does `js--maybe-goto-declaration-keyword-end` sound?
Good.
next prev parent reply other threads:[~2015-03-10 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 2:09 Requesting patch review Jackson Hamilton
2015-03-08 8:16 ` Thien-Thi Nguyen
2015-03-08 17:55 ` Dmitry Gutov
2015-03-08 22:01 ` Jackson Hamilton
2015-03-09 23:36 ` Dmitry Gutov
2015-03-10 1:34 ` Jackson Hamilton
2015-03-10 3:22 ` Stefan Monnier
2015-03-10 16:04 ` Dmitry Gutov [this message]
2015-03-10 23:39 ` Paul Eggert
2015-03-10 0:40 ` Running test/indent examples, Was: " Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF15F4.1020902@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).