From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding Date: Tue, 09 Apr 2019 16:38:12 +0100 Message-ID: <875zrnchp7.fsf@tcd.ie> References: <20190408204943.16965.86497@vcs0.savannah.gnu.org> <20190408204944.85B29209A7@vcs0.savannah.gnu.org> <87r2acayg5.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="234681"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 17:38:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDspp-000yuX-5t for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 17:38:53 +0200 Original-Received: from localhost ([127.0.0.1]:44779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDspn-0004Fq-L7 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 11:38:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDspG-0003mS-Go for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:38:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDspE-0000ha-Na for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:38:17 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:33686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDspE-0000eb-7z for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:38:16 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id b8so1869760edq.0 for ; Tue, 09 Apr 2019 08:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AOPaExuZBPAtKhcqSbGwwzHIrvo5vSOLVDFSflsmQJk=; b=Xo0+LXBZzWB8m3WvFtnVmXnIFSc5pYTV3JFa3gQbsQx4DIKAZgaZ/Oe0GxTyiAkj/Z O8kqWpQ+7wTnCcJ835vY96QDHGrC/uhfoclppqqMi9xOZXlB47Ry0q3zgj1kNmBo7qHZ hirnWRs7ZmGn1AuiRsfOIqetfnl9+T2/DxYLKvwk1qFd5W3eu3FQggDQPZBwiJz9G4ze o8LaUgJk+MqGVxEG5XaLC0+zO/p7mFuPINUAn8CIo7UqGvfUE0aCKwIzxUg+4XH45Mg9 2AFgNpL1u+x6eRKftTc6WYZ9nBRC1EPKhxuhcWbiNj+vIlV+2oTaGBsDhyManwtier4z i09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AOPaExuZBPAtKhcqSbGwwzHIrvo5vSOLVDFSflsmQJk=; b=VIKiRpTMcvfUrvgiLwkxLoijsrZqbS9SGUyx/l/ELo6a801aK/mKqToidlQE7YiozF 2my8AL/woLAR8ZydBNAUXiVLlh69PTbpmq4ecBbQcR/0XJOFNxlJnUsUmoQfZpKjm/Gd KoPAaybvngk91RbLgZGvoL2/4b796zNfSKMNI6NFsiYLzWQi+IKdEYW5zJYlk0wTj2/z 6fGOSrxeFuG+ZaJERAfvDrzOvJuASIQxOtYlTQDX0qWXGSyoRVpV0A08YP3r0Il98Ypu jOT85MNUd0KYq6z/kJIgfqRFIqD1VDCzJZisERg9BSMlGB/O8nW6V4a66HRafrcGosIX oryg== X-Gm-Message-State: APjAAAV3xeR7YeaJNRs7saxtQJnVBNh8jcsNOz+zgYcwN5xcY8EaaBgX IaB86c+5Iz/NFvSiXq2Ttg+G3Q== X-Google-Smtp-Source: APXvYqwgOlme9UmuRw/EqFBre5zNol1vSvf8QIwxMGZYw9EUQX24lHf2W1AKCuLn+QzfptZoBoH6Hg== X-Received: by 2002:a17:906:6c0d:: with SMTP id j13mr20791099ejr.249.1554824294250; Tue, 09 Apr 2019 08:38:14 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id l20sm9643200edq.20.2019.04.09.08.38.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Apr 2019 08:38:13 -0700 (PDT) In-Reply-To: (Andy Moreton's message of "Tue, 9 Apr 2019 16:11:17 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235168 Archived-At: Andy Moreton writes: > On Mon 08 Apr 2019, Stefan Monnier wrote: > >>> The dolist and while implementations aren't equivalent here (see my own >>> attempt at this[1] and the resulting bug[2]), so I took the liberty of >>> re-applying Yamaoka-san's fix[3] on top of your changes in the meantime. >> >> Duh, indeed, thanks, >> >> >> Stefan > > As this problem has now bitten twice, perhaps it merits a comment in the > code to prevent it being "fixed" again... Good point; done[1]. [1: e1a457e635]: ; Warn of while/dolist pitfall in gnus-sum.el 2019-04-09 16:32:27 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e1a457e63530cd566a1bc2957b70221bb6f76984 Thanks, -- Basil