* package-archives terminating slash
@ 2022-02-09 15:42 Robert Pluim
2022-02-09 17:16 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2022-02-09 15:42 UTC (permalink / raw)
To: emacs-devel
Hi,
if I do
M-: (add-to-list 'package-archives '("melpa" . "https://melpa.org/packages"))
M-x package-list-packages RET
then the package list retrieval works, but I get the following in
*Messages*, since Iʼve forgotten the trailing '/'
error in process filter: Error retrieving: https://melpa.org/packagesarchive-contents (error http 404)
We can (ab)use `file-name-concat' as follows, but is this too DWIM?
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 2e01449613..fdaab6f92d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1307,7 +1307,7 @@ package--unless-error
(cl-defun package--with-response-buffer-1 (url body &key async file error-function noerror &allow-other-keys)
(if (string-match-p "\\`https?:" url)
- (let ((url (concat url file)))
+ (let ((url (file-name-concat url file)))
(if async
(package--unless-error #'ignore
(url-retrieve
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: package-archives terminating slash
2022-02-09 15:42 package-archives terminating slash Robert Pluim
@ 2022-02-09 17:16 ` Andreas Schwab
2022-02-10 13:25 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2022-02-09 17:16 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
On Feb 09 2022, Robert Pluim wrote:
> Hi,
>
> if I do
>
> M-: (add-to-list 'package-archives '("melpa" . "https://melpa.org/packages"))
> M-x package-list-packages RET
>
> then the package list retrieval works, but I get the following in
> *Messages*, since Iʼve forgotten the trailing '/'
>
> error in process filter: Error retrieving: https://melpa.org/packagesarchive-contents (error http 404)
>
> We can (ab)use `file-name-concat' as follows, but is this too DWIM?
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index 2e01449613..fdaab6f92d 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1307,7 +1307,7 @@ package--unless-error
>
> (cl-defun package--with-response-buffer-1 (url body &key async file error-function noerror &allow-other-keys)
> (if (string-match-p "\\`https?:" url)
> - (let ((url (concat url file)))
> + (let ((url (file-name-concat url file)))
url-expand-file-name perhaps?
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: package-archives terminating slash
2022-02-09 17:16 ` Andreas Schwab
@ 2022-02-10 13:25 ` Robert Pluim
0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2022-02-10 13:25 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
>>>>> On Wed, 09 Feb 2022 18:16:11 +0100, Andreas Schwab <schwab@linux-m68k.org> said:
>> (cl-defun package--with-response-buffer-1 (url body &key async file error-function noerror &allow-other-keys)
>> (if (string-match-p "\\`https?:" url)
>> - (let ((url (concat url file)))
>> + (let ((url (file-name-concat url file)))
Andreas> url-expand-file-name perhaps?
Yes, thatʼs a much better function to use.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-10 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 15:42 package-archives terminating slash Robert Pluim
2022-02-09 17:16 ` Andreas Schwab
2022-02-10 13:25 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).