unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Subject: package-archives terminating slash
Date: Wed, 09 Feb 2022 16:42:44 +0100	[thread overview]
Message-ID: <87y22k2gi3.fsf@gmail.com> (raw)

Hi,

if I do

M-: (add-to-list 'package-archives '("melpa" . "https://melpa.org/packages"))
M-x package-list-packages RET

then the package list retrieval works, but I get the following in
*Messages*, since Iʼve forgotten the trailing '/'

error in process filter: Error retrieving: https://melpa.org/packagesarchive-contents (error http 404)

We can (ab)use `file-name-concat' as follows, but is this too DWIM?

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 2e01449613..fdaab6f92d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1307,7 +1307,7 @@ package--unless-error
 
 (cl-defun package--with-response-buffer-1 (url body &key async file error-function noerror &allow-other-keys)
   (if (string-match-p "\\`https?:" url)
-        (let ((url (concat url file)))
+        (let ((url (file-name-concat url file)))
           (if async
               (package--unless-error #'ignore
                 (url-retrieve



             reply	other threads:[~2022-02-09 15:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 15:42 Robert Pluim [this message]
2022-02-09 17:16 ` package-archives terminating slash Andreas Schwab
2022-02-10 13:25   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y22k2gi3.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).