unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master e869ae2: Fix EBROWSE parsing of classes declared final.
       [not found] ` <20190103120905.9C66320CAB@vcs0.savannah.gnu.org>
@ 2019-01-03 17:42   ` Glenn Morris
  2019-01-03 18:56     ` Andrey Kotlarski
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2019-01-03 17:42 UTC (permalink / raw)
  To: emacs-devel; +Cc: Andrey Kotlarski


Hi,

Re this:

> commit e869ae200db8378ab50957b8d357888e78fe0aac
>
>     Fix EBROWSE parsing of classes declared final.
> ---
>  ChangeLog.3       |  9 ++++++++
>  lib-src/ebrowse.c | 68 +++++++++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 63 insertions(+), 14 deletions(-)
>
> diff --git a/ChangeLog.3 b/ChangeLog.3
> index decee10..df2b167 100644
> --- a/ChangeLog.3
> +++ b/ChangeLog.3
> @@ -1,3 +1,12 @@
> +2019-01-03  Andrey Kotlarski  <m00naticus@gmail.com>
> +
> +	Fix EBROWSE parsing of classes declared final
> +
> +	* lib-src/ebrowse.c (enum token, token_string, init_scanner):
> +	Handle final keyword.
> +	(member, class_definition, globals): Correctly determine class
> +	name in presence of final declaration.
> +

ChangeLogs are automatically generated files (since some time) and should
not be edited directly. Instead what you wrote in ChangeLog.3 should
have been the commit message. No big deal though. If you had written
that entry to the unversioned file "ChangeLog", log-edit-insert-changelog
(C-c C-a) would have inserted it into the vc-log buffer. This is covered
in CONTRIBUTE.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master e869ae2: Fix EBROWSE parsing of classes declared final.
  2019-01-03 17:42   ` master e869ae2: Fix EBROWSE parsing of classes declared final Glenn Morris
@ 2019-01-03 18:56     ` Andrey Kotlarski
  0 siblings, 0 replies; 2+ messages in thread
From: Andrey Kotlarski @ 2019-01-03 18:56 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

Thanks for the head up, will know better next time.

[  3 януари 2019, 12:42 -0500, четвъртък ] Glenn Morris:

> Re this:
>
>> commit e869ae200db8378ab50957b8d357888e78fe0aac
>> ...
>
> ChangeLogs are automatically generated files (since some time) and should
> not be edited directly. Instead what you wrote in ChangeLog.3 should
> have been the commit message. No big deal though. If you had written
> that entry to the unversioned file "ChangeLog", log-edit-insert-changelog
> (C-c C-a) would have inserted it into the vc-log buffer. This is covered
> in CONTRIBUTE.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-03 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190103120903.22297.39666@vcs0.savannah.gnu.org>
     [not found] ` <20190103120905.9C66320CAB@vcs0.savannah.gnu.org>
2019-01-03 17:42   ` master e869ae2: Fix EBROWSE parsing of classes declared final Glenn Morris
2019-01-03 18:56     ` Andrey Kotlarski

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).