From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master e869ae2: Fix EBROWSE parsing of classes declared final. Date: Thu, 03 Jan 2019 12:42:45 -0500 Message-ID: <90ef9tvdre.fsf@fencepost.gnu.org> References: <20190103120903.22297.39666@vcs0.savannah.gnu.org> <20190103120905.9C66320CAB@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1546538329 17613 195.159.176.226 (3 Jan 2019 17:58:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 Jan 2019 17:58:49 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Andrey Kotlarski To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 03 18:58:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gf7GW-0004Ty-Rx for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2019 18:58:44 +0100 Original-Received: from localhost ([127.0.0.1]:57043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf7Id-0005Z7-Gk for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2019 13:00:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf715-0002iV-O4 for emacs-devel@gnu.org; Thu, 03 Jan 2019 12:42:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf715-0008An-30 for emacs-devel@gnu.org; Thu, 03 Jan 2019 12:42:47 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf714-0008Af-Vl; Thu, 03 Jan 2019 12:42:47 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gf713-0002h1-Pu; Thu, 03 Jan 2019 12:42:45 -0500 X-Spook: Craig Livingstone Ortega Tijuana Violence Cloud Bruxelles X-Ran: ~[,`$Wpmy3Yn3V]PG}`!4z1tLD-2R{JdH(QSo'lkxs7y+mQq/>.at#'27=VJvax0i$Cw@& X-Hue: brightyellow X-Attribution: GM In-Reply-To: <20190103120905.9C66320CAB@vcs0.savannah.gnu.org> (Andrey Kotlarski's message of "Thu, 3 Jan 2019 07:09:05 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232142 Archived-At: Hi, Re this: > commit e869ae200db8378ab50957b8d357888e78fe0aac > > Fix EBROWSE parsing of classes declared final. > --- > ChangeLog.3 | 9 ++++++++ > lib-src/ebrowse.c | 68 +++++++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 63 insertions(+), 14 deletions(-) > > diff --git a/ChangeLog.3 b/ChangeLog.3 > index decee10..df2b167 100644 > --- a/ChangeLog.3 > +++ b/ChangeLog.3 > @@ -1,3 +1,12 @@ > +2019-01-03 Andrey Kotlarski > + > + Fix EBROWSE parsing of classes declared final > + > + * lib-src/ebrowse.c (enum token, token_string, init_scanner): > + Handle final keyword. > + (member, class_definition, globals): Correctly determine class > + name in presence of final declaration. > + ChangeLogs are automatically generated files (since some time) and should not be edited directly. Instead what you wrote in ChangeLog.3 should have been the commit message. No big deal though. If you had written that entry to the unversioned file "ChangeLog", log-edit-insert-changelog (C-c C-a) would have inserted it into the vc-log buffer. This is covered in CONTRIBUTE.