From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: TRAMP VC optimization fails: non-TRAMP filenames handled incorrectly in async operations. Date: Wed, 27 Mar 2019 18:49:41 +0100 Message-ID: <8736n8i4wa.fsf@gmx.de> References: <87bm1wmhw6.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255822"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: Daniel Pittman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 18:50:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9Ch1-0014RC-E0 for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 18:50:27 +0100 Original-Received: from localhost ([127.0.0.1]:51494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Ch0-0000EZ-8U for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 13:50:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9CgM-0000DN-1p for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:49:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9CgL-0000jM-0N for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:49:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:40835) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9CgK-0000fL-JV for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1553708982; bh=xtwHclhyVRq34wLhtxjdZIJRV340+jN7o3fgSt5ed+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=hKGroWVCq0RFhK7knazfcpJINnyM1l4EYaiVFnKD8fvu/eUwdy2tee49pSxMAGq66 JGQLVf5W7iXsPwPkORtfn+F3Jo4gN5hQ3drGC+q6riLPnvbYwFWxXTzA/eY+uQ/Ci7 OyJUPsw5aRWAAjAVMLl3QKdY/GWllmi6EKRZWd/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.37.206]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MZfZi-1hPDvk13Hi-00LY3z; Wed, 27 Mar 2019 18:49:42 +0100 In-Reply-To: (Daniel Pittman's message of "Wed, 27 Mar 2019 16:22:58 +0000") X-Provags-ID: V03:K1:ha11lCF/RaWH+RIrVz48fISi35HotZ7EUI5r0EIBbVVf7o75onT WqTxqTmRXzwVHykWwcSvSldJnbsng2T2OapmmQQ1Kyb0zptKt+22AhrrElX10A8ccBWpLD3 iZtRUJKK/osRV2JSarFAnYqUFuNMySry4hcJsIyWb+sqpz0wknZstEVKeI5EoshIFRF29+a I0CL0WSIUzWVAD8HQc+ow== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ws3PqwMcBmM=:GFtsILPjZa6m82gbcMW3fi Pw3kmVoCqZ7KEMGYIWFGrQKwO5gSwtBhJcYXEaaA0Np5IrHIPV4puU6Y2qjCAciSkLu4iIZ0+ 5mNWOwUKBIdh1QZgMDMf+YWYEqJojlaEUVf50FYvdqIndXa2k2gN5TCI6VsUMif26rSAY/LXT LpT/yf0CzHfTcQ4nopeQswyBJ1iA6j1rtZJx0UadPaYSKd8dWQZhcVi7hTpA641t8DHlH/bQn d9ae7EA9yBNHa5EAkgcsbQdjXDgrNtB+b74GAIVTn89YG24zkOnisieLcRSAs4tMWXYzHyY/H tHzCi3CM2n10ujKfCq6EitaCtBF8siA4Vin2kUlck7utDUgVC+OX7/Lm3583/qb1Z2XhvAoT6 4qrz8iePeTIGAaOCxteYPaHv+RVnKghJ1fvX8rx+n84f+p8xN6Xx4+6b1L/ZZIpD0047qHRmv cwVq7w5VzeeYjuaQSsdsV3t57iCUUcY6RjdiKfme2axFdXz/9FbkuTuERs6uSHalI9bd/zJu8 WEw9mE2nCltte4sy9w7j+EN2P2TXBsMiT7IRBSxoC/iLyux7fwnBT6QTVjivCtwwzX8k56kza MyLDO76WfMqbsLqwvNA8GCXEwBx46PJuGYWKJN9GpHXmGl3hFZEFxWlq5NOnsQa0AqyPD6qJ+ S7tgdqQXmmFNFsXmm+Yg/tUx76OOFHub1AmQKduSE286FGbVfCFdG00BV3Dy/AglC9wkxOXA1 zg8qlhQATMWQSvvoEnrKXBLijQVjYlhcUCzIcyslk3K/TmpSqYXLhhLyhPGuxKsYxmXG7kyZ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234783 Archived-At: Daniel Pittman writes: Hi Daniel, > My best guess is that we should disable that optimization for now, and > if desirable, reapproach it. Before doing this, I'd like to check whether there is a simple solution. > One possibly functional strategy, but that I have not considered all > possible angles of, might be to fetch the path and then if `(not > (tramp-file-name-p ...))` dispatch to the original file name handlers. > I think that would absolutely work as long as none of those callbacks > interacted with a tramp path at all, and it .... might, but probably > wouldn't, if they did. In your initial message you've said, that the problem happened inside tramp-vc-file-name-handler. Is this always the case? If yes, I could simply catch errors inside this function, and in case of, throw away all results. This would fall back to the non-optimized solution by default. Since I cannot reproduce the problem (yet), do you have a backtrace? Setting tramp-verbose to 10 would suffice, because with this verbosity, any error triggers Tramp to write the backtrace into the debug buffer. > Historically, I attached a tramp operation to copy the generated > server(-start) key to a remote tramp path, since I used a TCP > listener, ssh forwarding, and that shared secret to allow remote > emacsclient to work. That could have triggered at any point after > tramp reconnected, as it advised a fairly low level tramp function. > I'm not sure how common (or cared about) that sort of nastly hack is, > but I'm not confident that more legitimate ways to do the same could > be in use in the wild. Sorry, I don't follow here :-( How is this related? Best regards, Michael.