* Re: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate
[not found] ` <20201231042859.C7E3C21074@vcs0.savannah.gnu.org>
@ 2020-12-31 9:34 ` Stefan Kangas
2020-12-31 16:47 ` Drew Adams
2021-01-01 4:46 ` Lars Ingebrigtsen
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Kangas @ 2020-12-31 9:34 UTC (permalink / raw)
To: Lars Ingebrigtsen, emacs-devel
larsi@gnus.org (Lars Ingebrigtsen) writes:
> branch: master
> commit b1ac23ebef62d5a185727a4973462828dc6f65f0
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Allow add-to-ordered-list to use a test predicate
>
> * doc/lispref/lists.texi (List Variables): Update manual.
>
> * lisp/subr.el (add-to-ordered-list): Allow using a test
> predicate, and make slightly more efficient (bug#45539).
It seems like this commit broke some tests:
Ran 6 tests, 2 results as expected, 4 unexpected (2020-12-31
10:24:11+0100, 0.402251 sec)
4 unexpected results:
FAILED viper-test-undo-1
FAILED viper-test-undo-2
FAILED viper-test-undo-3
FAILED viper-test-undo-4
make[1]: *** [Makefile:178: lisp/emulation/viper-tests.log] Error 1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate
2020-12-31 9:34 ` master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate Stefan Kangas
@ 2020-12-31 16:47 ` Drew Adams
2021-01-01 4:46 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Drew Adams @ 2020-12-31 16:47 UTC (permalink / raw)
To: Stefan Kangas, Lars Ingebrigtsen, emacs-devel
> > * lisp/subr.el (add-to-ordered-list): Allow using a test
> > predicate, and make slightly more efficient (bug#45539).
>
> It seems like this commit broke some tests:
FWIW, I don't think that bug is finished being fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate
2020-12-31 9:34 ` master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate Stefan Kangas
2020-12-31 16:47 ` Drew Adams
@ 2021-01-01 4:46 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-01 4:46 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefan@marxist.se> writes:
> It seems like this commit broke some tests:
>
> Ran 6 tests, 2 results as expected, 4 unexpected (2020-12-31
> 10:24:11+0100, 0.402251 sec)
>
> 4 unexpected results:
> FAILED viper-test-undo-1
> FAILED viper-test-undo-2
> FAILED viper-test-undo-3
> FAILED viper-test-undo-4
Right -- my changes here were misguided, because it didn't allow
changing the value of the variable from outside the function.
I've now reverted the change, and there won't be any test-function here,
because the semantics would be too unclear -- the hash table and the
membership function have to use the same predicate, which means that the
first call creates state, and subsequent calls may or may not work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-01 4:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201231042857.21579.10882@vcs0.savannah.gnu.org>
[not found] ` <20201231042859.C7E3C21074@vcs0.savannah.gnu.org>
2020-12-31 9:34 ` master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate Stefan Kangas
2020-12-31 16:47 ` Drew Adams
2021-01-01 4:46 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).