From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate Date: Fri, 01 Jan 2021 05:46:59 +0100 Message-ID: <8735zle01o.fsf@gnus.org> References: <20201231042857.21579.10882@vcs0.savannah.gnu.org> <20201231042859.C7E3C21074@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35279"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 01 05:48:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvCLu-0008Y0-1j for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Jan 2021 05:47:50 +0100 Original-Received: from localhost ([::1]:59478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvCLt-0001zB-3N for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Dec 2020 23:47:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvCLN-0001ZF-Gu for emacs-devel@gnu.org; Thu, 31 Dec 2020 23:47:17 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:43906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvCLL-0002Fk-LU for emacs-devel@gnu.org; Thu, 31 Dec 2020 23:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Co0kVDXZ7FPWZTJloLCXiRq6t4WQadJIahhQCFXKA48=; b=K4pCVRYV1RcBwHKjcWkNV+XDqE 0UggFYeU+1BrWjkm5jYQIW6VVK//JBVhZNCMs+vHcYKjkXmrvHnC5cmMexRux+rxsmyVjNIfjIila fGm7MBF7rZDx6CLeaTrl/yZiBSCGDUKZ2XmrYJ44SmLoNFFvJcNIvF2D3jS9VNzlruLo=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvCL6-0003DN-MR; Fri, 01 Jan 2021 05:47:10 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUJBgRWOStbWCkr JheYh16Yj1b///+PvribAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UBAQQsKuoCZOAAAAGxSURBVDjL bdNdkpwgEADgVrLvIpV3aTPvYM8Bklm8gBXuf5XtH5QxG6rGQT6anwYBAGaQQvoEzyVnv0k93yBQ CEP+Djn4kB11cN5gnogoGzh5/AgGcUku5anDx6TtLiR5Tn0oAUcwGiwKg9Q/tD+Nq7zA0ocabaQ5 3MDBWVpEMEiQLkBdRDxBQ0S3/Fv3f0E6YfvUNFg2uGVtSdmeyyI78CdsDWicuLPL8YRxMXSDbius J8CnATDwutIVAaUBb0oWfM0Bz5aBG5AlzOnstvQO0DZDFmjgoHcleaY7UGAkgjtQAiKZJ+l7OEE7 tg7y3w4atrXdHpIeHZ4l0iTLzZhfejZ6A+ZX2TEcnlbCii+UoAkI8VFKqWs9gsdHLRUxBgau/xU4 ao2b1HeWFfS0af5VyrHXOgtU9AT9EszcXpF/f+wCXAAbN/JwdYE7UN4vgA4OInVI70Dw8//AH0h9 dHBvMFRkeDSgDrAj1oNBcx3sq7DbiZHTM8mElIOlOgkMmCUZEmHnKGeg31ckaddxbXIiZ5HOp3Zn zlXZEZOeq853wQq9JOjLfQN3B/o3In0HbXPwBf/YUAbm7TZEAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIxLTAxLTAxVDA0OjQ0OjQxKzAwOjAwOYiv2wAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0w MVQwNDo0NDo0MSswMDowMEjVF2cAAAAASUVORK5CYII= X-Now-Playing: Psychic TV's _Dreams Less Sweet_: "White Nights" In-Reply-To: (Stefan Kangas's message of "Thu, 31 Dec 2020 01:34:59 -0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262212 Archived-At: Stefan Kangas writes: > It seems like this commit broke some tests: > > Ran 6 tests, 2 results as expected, 4 unexpected (2020-12-31 > 10:24:11+0100, 0.402251 sec) > > 4 unexpected results: > FAILED viper-test-undo-1 > FAILED viper-test-undo-2 > FAILED viper-test-undo-3 > FAILED viper-test-undo-4 Right -- my changes here were misguided, because it didn't allow changing the value of the variable from outside the function. I've now reverted the change, and there won't be any test-function here, because the semantics would be too unclear -- the hash table and the membership function have to use the same predicate, which means that the first call creates state, and subsequent calls may or may not work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no