unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 5065698: Move the ‘declare’ form before the interactive spec in 10 functions.
Date: Fri, 22 Jan 2021 10:50:05 +0200	[thread overview]
Message-ID: <8735yte4oy.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvr1mdx1r0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 21 Jan 2021 19:22:05 -0500")

>> -                   (t (message "Warning: Unknown defun property `%S' in %S"
>> -                               (car x) name)))))
>> +                   (t (message "%S:%d:Warning: Unknown defun property `%S'"
>> +                               name (count-lines (point-min) (point))
>> +                               (car x))))))
>
> I think `count-lines` is a problem because we don't know in which buffer
> we are when this is executed.

The GNU Coding Standard format requires a line number between colons,
so maybe count-lines would give some plausible number in most cases.

> Another approach could be to use something like
> `macroexp--warn-and-return`.

`macroexp--warn-and-return` uses `load-file-name` that is nil here.
Or do you mean the docstring of `macroexp--funcall-if-compiled`:

  The purpose is to delay warnings to bytecomp.el, so they can use things
  like `byte-compile-warn' to get better file-and-line-number data
  and also to avoid outputting the warning during normal execution.

I tried it, but it has no effect.

  (let ((warnfun (lambda ()
                   (message "Warning: Unknown defun property `%S' in %S"
                            (car x) name))))
    `(progn
       (macroexp--funcall-if-compiled ',warnfun)))



  reply	other threads:[~2021-01-22  8:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210120191935.5488.54008@vcs0.savannah.gnu.org>
     [not found] ` <20210120191936.DCB55209AB@vcs0.savannah.gnu.org>
2021-01-20 21:02   ` master 5065698: Move the ‘declare’ form before the interactive spec in 10 functions Stefan Monnier
2021-01-20 21:36     ` Juri Linkov
2021-01-20 21:03   ` Lars Ingebrigtsen
2021-01-20 21:35     ` Juri Linkov
2021-01-20 21:50       ` Juri Linkov
2021-01-20 22:00         ` Dmitry Gutov
2021-01-20 22:19           ` Juri Linkov
2021-01-21 21:52             ` Juri Linkov
2021-01-21 22:01               ` Stefan Monnier
2021-01-21 22:32                 ` Juri Linkov
2021-01-22  0:22                   ` Stefan Monnier
2021-01-22  8:50                     ` Juri Linkov [this message]
2021-01-22 14:04                       ` Stefan Monnier
2021-01-23 17:33                         ` Juri Linkov
2021-01-23 18:01                           ` Stefan Monnier
2021-01-23 18:56                             ` Juri Linkov
2021-01-23 19:57                               ` Stefan Monnier
2021-01-23 20:14                                 ` Juri Linkov
2021-01-23 20:49                                   ` Stefan Monnier
2021-01-23 21:05                                   ` Stefan Monnier
2021-01-20 21:58     ` Juri Linkov
2021-01-20 22:09       ` Lars Ingebrigtsen
2021-01-22  2:13         ` Mike Kupfer
2021-01-22 18:22           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735yte4oy.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).