From: Mike Kupfer <mkupfer@alum.berkeley.edu>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Subject: Re: master 5065698: Move the ‘declare’ form before the interactive spec in 10 functions.
Date: Thu, 21 Jan 2021 18:13:56 -0800 [thread overview]
Message-ID: <843.1611281636@alto> (raw)
In-Reply-To: Your message of "Wed, 20 Jan 2021 23:09:13 +0100." <878s8nl0qe.fsf@gnus.org>
Lars Ingebrigtsen wrote:
> Juri Linkov <juri@linkov.net> writes:
>
> > I wonder what the intention was to do here
I tried to track this down. (declare (ignore VAR)) is a Common Lisp
thing, to tell the compiler that VAR is unused in the function (so don't
warn about it being unused). My CL reference doesn't mention "args" as
a pseudo-variable that could be used with ignore. But it's an ancient
reference; I don't know what the current standard allows.
Based on iterating with "git blame", it looks like the (declare
(ignore...)) stuff was introduced with MH-E 7.0, which I think was the
first MH-E release that had speedbar support. I don't know why a CL
construct was used here, or why the arguments are ignored. Maybe Bill
Wohler remembers.
> > , what is the closest
> > valid thing? Maybe
> >
> > (declare (advertised-calling-convention (&rest ignored) "28.1"))
>
> I think just
>
> (defun mh-speed-toggle (&rest _ignored)
>
> would be fine?
Seems reasonable to me.
cheers,
mike
next prev parent reply other threads:[~2021-01-22 2:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210120191935.5488.54008@vcs0.savannah.gnu.org>
[not found] ` <20210120191936.DCB55209AB@vcs0.savannah.gnu.org>
2021-01-20 21:02 ` master 5065698: Move the ‘declare’ form before the interactive spec in 10 functions Stefan Monnier
2021-01-20 21:36 ` Juri Linkov
2021-01-20 21:03 ` Lars Ingebrigtsen
2021-01-20 21:35 ` Juri Linkov
2021-01-20 21:50 ` Juri Linkov
2021-01-20 22:00 ` Dmitry Gutov
2021-01-20 22:19 ` Juri Linkov
2021-01-21 21:52 ` Juri Linkov
2021-01-21 22:01 ` Stefan Monnier
2021-01-21 22:32 ` Juri Linkov
2021-01-22 0:22 ` Stefan Monnier
2021-01-22 8:50 ` Juri Linkov
2021-01-22 14:04 ` Stefan Monnier
2021-01-23 17:33 ` Juri Linkov
2021-01-23 18:01 ` Stefan Monnier
2021-01-23 18:56 ` Juri Linkov
2021-01-23 19:57 ` Stefan Monnier
2021-01-23 20:14 ` Juri Linkov
2021-01-23 20:49 ` Stefan Monnier
2021-01-23 21:05 ` Stefan Monnier
2021-01-20 21:58 ` Juri Linkov
2021-01-20 22:09 ` Lars Ingebrigtsen
2021-01-22 2:13 ` Mike Kupfer [this message]
2021-01-22 18:22 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=843.1611281636@alto \
--to=mkupfer@alum.berkeley.edu \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).