From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Fri, 22 Jan 2021 10:50:05 +0200 Organization: LINKOV.NET Message-ID: <8735yte4oy.fsf@mail.linkov.net> References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> <87v9bp7wft.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2610"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 22 09:58:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2sGt-0000VZ-3T for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 09:58:23 +0100 Original-Received: from localhost ([::1]:58970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2sGs-0005HA-5l for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 03:58:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2sFl-0004ba-Uk for emacs-devel@gnu.org; Fri, 22 Jan 2021 03:57:13 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2sFd-0007Ou-00 for emacs-devel@gnu.org; Fri, 22 Jan 2021 03:57:09 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 2C1DEFF802; Fri, 22 Jan 2021 08:56:59 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 21 Jan 2021 19:22:05 -0500") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263268 Archived-At: >> - (t (message "Warning: Unknown defun property `%S' in %S" >> - (car x) name))))) >> + (t (message "%S:%d:Warning: Unknown defun property `%S'" >> + name (count-lines (point-min) (point)) >> + (car x)))))) > > I think `count-lines` is a problem because we don't know in which buffer > we are when this is executed. The GNU Coding Standard format requires a line number between colons, so maybe count-lines would give some plausible number in most cases. > Another approach could be to use something like > `macroexp--warn-and-return`. `macroexp--warn-and-return` uses `load-file-name` that is nil here. Or do you mean the docstring of `macroexp--funcall-if-compiled`: The purpose is to delay warnings to bytecomp.el, so they can use things like `byte-compile-warn' to get better file-and-line-number data and also to avoid outputting the warning during normal execution. I tried it, but it has no effect. (let ((warnfun (lambda () (message "Warning: Unknown defun property `%S' in %S" (car x) name)))) `(progn (macroexp--funcall-if-compiled ',warnfun)))