* Re: master b968323: Fix previous face.el change
[not found] ` <20210322191809.D85B920D10@vcs0.savannah.gnu.org>
@ 2021-03-24 5:03 ` Stefan Kangas
2021-03-24 8:23 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-03-24 5:03 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
larsi@gnus.org (Lars Ingebrigtsen) writes:
> branch: master
> commit b9683230ecaada87f23bdba59ef044c4b0374216
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Fix previous face.el change
>
> * lisp/faces.el (require): Fix compilation warning from previous
> face.el change.
> ---
> lisp/faces.el | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 3ea4c94..1067556 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -25,6 +25,8 @@
>
> ;;; Code:
>
> +(eval-when-compile (require 'subr-x))
> +
This commit breaks bootstrap here:
Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Loading /home/skangas/wip/emacs/lisp/cus-face.el (source)...
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
[... snip ...]
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
make[3]: *** [Makefile:279: emacs-lisp/autoload.elc] Segmentation fault
I find `string-trim' an obviously useful addition to Emacs Lisp, so I
suggest moving it to subr.el instead.
That might call for adding it to the ELisp Manual as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b968323: Fix previous face.el change
2021-03-24 5:03 ` master b968323: Fix previous face.el change Stefan Kangas
@ 2021-03-24 8:23 ` Lars Ingebrigtsen
2021-03-24 20:42 ` Basil L. Contovounesios
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-24 8:23 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
Stefan Kangas <stefan@marxist.se> writes:
> This commit breaks bootstrap here:
>
> Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
Oops.
> I find `string-trim' an obviously useful addition to Emacs Lisp, so I
> suggest moving it to subr.el instead.
>
> That might call for adding it to the ELisp Manual as well.
OK; done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b968323: Fix previous face.el change
2021-03-24 8:23 ` Lars Ingebrigtsen
@ 2021-03-24 20:42 ` Basil L. Contovounesios
2021-03-25 9:07 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Basil L. Contovounesios @ 2021-03-24 20:42 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Stefan Kangas, emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Kangas <stefan@marxist.se> writes:
>
>> I find `string-trim' an obviously useful addition to Emacs Lisp, so I
>> suggest moving it to subr.el instead.
>>
>> That might call for adding it to the ELisp Manual as well.
>
> OK; done.
Does that warrant a NEWS announcement?
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b968323: Fix previous face.el change
2021-03-24 20:42 ` Basil L. Contovounesios
@ 2021-03-25 9:07 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-25 9:07 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: Stefan Kangas, emacs-devel
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Does that warrant a NEWS announcement?
It's not really a functional change, so people don't have to do anything
about it (except stop requiring subr-x so much), so it doesn't seem to
warrant a NEWS entry.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-25 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210322191808.723.93761@vcs0.savannah.gnu.org>
[not found] ` <20210322191809.D85B920D10@vcs0.savannah.gnu.org>
2021-03-24 5:03 ` master b968323: Fix previous face.el change Stefan Kangas
2021-03-24 8:23 ` Lars Ingebrigtsen
2021-03-24 20:42 ` Basil L. Contovounesios
2021-03-25 9:07 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).