From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master b968323: Fix previous face.el change Date: Wed, 24 Mar 2021 00:03:14 -0500 Message-ID: References: <20210322191808.723.93761@vcs0.savannah.gnu.org> <20210322191809.D85B920D10@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 06:05:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOvha-00068y-Tn for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 06:05:06 +0100 Original-Received: from localhost ([::1]:44844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOvhZ-0002Iu-Ps for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 01:05:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOvfr-0001L1-JR for emacs-devel@gnu.org; Wed, 24 Mar 2021 01:03:19 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:46605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOvfo-0000AO-Q9 for emacs-devel@gnu.org; Wed, 24 Mar 2021 01:03:18 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id x126so16474169pfc.13 for ; Tue, 23 Mar 2021 22:03:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=XWeRxiUgc91gpHTf/S8Wx+B59+QbXv4xTNRPymU5r48=; b=U7CV4C+1aXLHdFkEcxorJeabbrUKabc066GzMkF3UEhXnDm7/nDPYyLCYXOvhoirU/ 08kmy2F0j7Y4js/b6niiu85yaLUSsT1aIfLEM8zpLQYIwWW0oXB+c7EC2V5gF5KgJbu9 2RmiORvW1xtyVqwATH7RDhRZqJiG7CsMDctDDow6P8Yn7W6NUcACyzhXB0uXEa5zteaN pPpTMggeBlSKm68YdVSJlWInW/HM7Wylz3dXAyx7OV69Ss8DvElwXWR8wMV/FZHT/8Wz +NyOM6E8/oE0L9Z+01+3/bFFv+c9bBfSfHJDMkAqX2flt89Q0AErvopBtYDg/5xErip/ cFnQ== X-Gm-Message-State: AOAM532LVLdf0mChjsIuyNZHx/DSekFczk3fIOuZ4XBaemnvgXlMtZ2d d2duLf74RMz6m6Typ4/NxYUgiFpqgqZUO4sMbrs= X-Google-Smtp-Source: ABdhPJwymDwR4NcniK0c+zcgGs2Kk60JaAfweaxx6Y8nI0PYnc1L/dL2GxpfVS/5Fb8vUGthDaSwj2GTeCPvVwDB7X8= X-Received: by 2002:a63:1e20:: with SMTP id e32mr1473971pge.345.1616562194597; Tue, 23 Mar 2021 22:03:14 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 24 Mar 2021 00:03:14 -0500 In-Reply-To: <20210322191809.D85B920D10@vcs0.savannah.gnu.org> Received-SPF: pass client-ip=209.85.210.178; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f178.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266914 Archived-At: larsi@gnus.org (Lars Ingebrigtsen) writes: > branch: master > commit b9683230ecaada87f23bdba59ef044c4b0374216 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Fix previous face.el change > > * lisp/faces.el (require): Fix compilation warning from previous > face.el change. > --- > lisp/faces.el | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lisp/faces.el b/lisp/faces.el > index 3ea4c94..1067556 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -25,6 +25,8 @@ > > ;;; Code: > > +(eval-when-compile (require 'subr-x)) > + This commit breaks bootstrap here: Loading /home/skangas/wip/emacs/lisp/faces.el (source)... Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Loading /home/skangas/wip/emacs/lisp/cus-face.el (source)... Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Loading /home/skangas/wip/emacs/lisp/faces.el (source)... Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) [... snip ...] Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) Eager macro-expansion failure: (void-variable read-file-name-completion-ignore-case) make[3]: *** [Makefile:279: emacs-lisp/autoload.elc] Segmentation fault I find `string-trim' an obviously useful addition to Emacs Lisp, so I suggest moving it to subr.el instead. That might call for adding it to the ELisp Manual as well.