From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: native-comp *Warnings* buffer Date: Thu, 13 May 2021 15:00:46 -0700 Message-ID: <8735uqz435.fsf@ericabrahamsen.net> References: <87k0o2z9pr.fsf@ericabrahamsen.net> <87fsyqz8pi.fsf@ericabrahamsen.net> <87bl9ez5an.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25589"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andrea Corallo To: Andrea Corallo via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 14 00:02:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhJPF-0006Yn-Fl for ged-emacs-devel@m.gmane-mx.org; Fri, 14 May 2021 00:02:09 +0200 Original-Received: from localhost ([::1]:35876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhJPE-00041P-I3 for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 18:02:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhJO9-00034z-UN for emacs-devel@gnu.org; Thu, 13 May 2021 18:01:03 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:55712 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhJNy-0006x6-Aq for emacs-devel@gnu.org; Thu, 13 May 2021 18:01:01 -0400 Original-Received: from localhost (c-71-197-184-122.hsd1.wa.comcast.net [71.197.184.122]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 639C3FED1B; Thu, 13 May 2021 22:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1620943248; bh=BIrm6g/3sclzZNHbzahS7UjGMup3y5ZLIxrAiYfLcRU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=o8oNKB3SnZqBROLY/AJzhGEnuQsLcRak7e/xwp/T9oE27etcUu3/XGoE1F+KuMhhr dbDHfE4MNIwm+j698eeTLo3niUSMcxYPpsA3CyIHILIq0tEVRBafj7KirlHzW4tYIe Vibo5rYVqGEd+Tf2+1p9oaOmuhw4hN5cZNHpTBVU= In-Reply-To: <87bl9ez5an.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 13 May 2021 14:34:40 -0700") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269261 Archived-At: Eric Abrahamsen writes: > Andrea Corallo via "Emacs development discussions." > writes: > >> Eric Abrahamsen writes: >> >>> Eric Abrahamsen writes: >>> >>>> I understand the utility of having these warnings, but does the buffer >>>> need to be popped up every thirty seconds? Couldn't it just be display= ed >>>> once, when it's created, and then left alone? Compilation has been goi= ng >>>> on for several minutes since rebuilding Emacs, and it's actually hard = to >>>> use with *Warnings* occupying my other window every few seconds! >>> >>> I should say that I know about >>> `native-comp-async-report-warnings-errors', and I'd actually like to see >>> these warnings (as many of them are about my own code :(), I'd just like >>> to have them in the background. >> >> Hi Eric, >> >> unfortunately new warnings are showed when they are found while >> compiling. I agree this is annoying but at the same time I'm not sure >> this behavior wrong. >> >> Anyway in comp.el we just call `display-warning'. If there's a better >> way to handle this any suggestion or patch is very welcome :) > > It looks like `warning-suppress-types' might do it! > > List of warning types not to display immediately. > If any element of this list matches the TYPE argument to =E2=80=98display= -warning=E2=80=99, > the warning is logged nonetheless, but the warnings buffer is > not immediately displayed. > The element must match an initial segment of the list TYPE. > Thus, (foo bar) as an element matches (foo bar) > or (foo bar ANYTHING...) as TYPE. > If TYPE is a symbol FOO, that is equivalent to the list (FOO), > so only the element (FOO) will match it. > > Let-binding this with 'comp in the value should do it. > > We could add 'suppress or 'quiet as an alternate value > `native-comp-async-report-warnings-errors', and use that to optionally > change the value of `warning-suppress-types'. Well I guess I could have figured this out myself: the clickable "Disable showing" button at the end of every warning does exactly this: customizes `warning-suppress-types' so that the '(comp) warnings are still logged to *Warnings*, but it doesn't pop up the buffer. This seems like enough customization to me, and there's no need to add any code! Actually it looks like `native-comp-async-report-warnings-errors' could be replaced by customization of `warning-suppress-log-types', which will prevent logging altogether. Anyway, problem solved!