* Re: master 5c99647: Error out on invalid `define-keymap' keywords
[not found] ` <20211019025111.08E2521120@vcs0.savannah.gnu.org>
@ 2022-01-03 15:11 ` Robert Pluim
2022-01-05 16:11 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Robert Pluim @ 2022-01-03 15:11 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
>>>>> On Mon, 18 Oct 2021 22:51:10 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:
Lars> diff --git a/lisp/vc/cvs-status.el b/lisp/vc/cvs-status.el
Lars> index 723f277..86b62eb 100644
Lars> --- a/lisp/vc/cvs-status.el
Lars> +++ b/lisp/vc/cvs-status.el
Lars> @@ -35,7 +35,7 @@
Lars> ;;;
Lars> (defvar-keymap cvs-status-mode-map
Lars> - :inherit 'cvs-mode-map
Lars> + :parent 'cvs-mode-map
Lars> "n" #'next-line
Lars> "p" #'previous-line
Lars> "N" #'cvs-status-next
Shouldn't this be
:parent cvs-mode-map
(without the quote). I guess emacs-28 needs a similar fix (although I
haven't noticed any negative side effects of it, but then again I
donʼt use CVS at all)
Robert
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 5c99647: Error out on invalid `define-keymap' keywords
2022-01-03 15:11 ` master 5c99647: Error out on invalid `define-keymap' keywords Robert Pluim
@ 2022-01-05 16:11 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-05 16:11 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> Shouldn't this be
>
> :parent cvs-mode-map
>
> (without the quote).
Yup. Now fixed.
> I guess emacs-28 needs a similar fix (although I haven't noticed any
> negative side effects of it, but then again I donʼt use CVS at all)
I'm guessing this isn't used a lot, since it's apparently been this way
for a couple of decades. (And since it's not a regression, I don't
think we should fix this in emacs-28 at this point.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-05 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211019025109.11255.56785@vcs0.savannah.gnu.org>
[not found] ` <20211019025111.08E2521120@vcs0.savannah.gnu.org>
2022-01-03 15:11 ` master 5c99647: Error out on invalid `define-keymap' keywords Robert Pluim
2022-01-05 16:11 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).