From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 5c99647: Error out on invalid `define-keymap' keywords Date: Mon, 03 Jan 2022 16:11:25 +0100 Message-ID: <87v8z07t2a.fsf@gmail.com> References: <20211019025109.11255.56785@vcs0.savannah.gnu.org> <20211019025111.08E2521120@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 03 16:15:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4P3B-0008P3-74 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 16:15:05 +0100 Original-Received: from localhost ([::1]:52666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4P39-0003vR-U3 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 10:15:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4Ozh-0008Qm-W2 for emacs-devel@gnu.org; Mon, 03 Jan 2022 10:11:30 -0500 Original-Received: from [2a00:1450:4864:20::434] (port=33486 helo=mail-wr1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4Ozg-0008EM-Bh for emacs-devel@gnu.org; Mon, 03 Jan 2022 10:11:29 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id d9so70563524wrb.0 for ; Mon, 03 Jan 2022 07:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=yg1iaWMpxk63hb4xgurdE5vBZKyw2I2INlWvO/B0LTQ=; b=ipnZkSD2LsPgLdiDbMHAKg5q4LibE3LQvjEZpkhG78NsLJUPJgfSV2VZ5VszKPttfD QBued5pHES+BkUC4KdzDqHwXQ9S3KZjuADSlGoc5DlvIrFmgzpp6EIrDhY6dg+NFHGr9 v04EQjBCWNwdn5pDi9tRD1jVnFoXpSiPW9mQLrPOaLBGQ0I/rwjsGCnI4didFp5X9nBt p1kb9j8LqrKf5t4wErWPTNxFilkXJ5B6fhxoyXPYx/VnlEjA96M4ve77txZWCAfWpHgr UV/vk2VUtxWR5+z0l+I5BSUHgWZGhPnFxwyaVmmJfpmr7Uyv1siyf/oVBJjT/9MDEyxT VQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=yg1iaWMpxk63hb4xgurdE5vBZKyw2I2INlWvO/B0LTQ=; b=Vx4NmoBMDvmX3M1+B02QKASIfDfS8Cc97Hk63Va8IZlrRlnW8oLaUBJ3hOlZq/awmF hPZa5baC1M37inqTHBR15V+fh64BPCfhMf1ASFHaXcQVO8gEJj4jKxLg8MRLHQGy6S66 785M+EHjVBKyK+fqfnb13MJIv5ee2+7IrbamHva71fz5La3fMa46b5tbEFdz1QXmJsU+ dLdbxZQDDFzrMhunqK9KLshCDhVtmXUN3Z+yHJ3FhKY8BebMgtQR8NBCuLl3yDrtTGM/ iu9bTumZoBXnfUvSAeNxetNXx6Tt+L4T9ysnv04wnJiVYZKv5yDYjuX2YKR2ps1qwAQ7 x9PA== X-Gm-Message-State: AOAM530hStZPwzT4GESEpVQJmsXgqMecJ0D6d045Nit4fAElDZoWBHih 6/OVh1Znim20ibVzKc2I9IU= X-Google-Smtp-Source: ABdhPJxWH28Zk3rNVY6J+7rbudhoC6jK0qEBYnSrURpo1Ag9wqr0w+DTcENBmpe+A1lAx4mJGc3TIg== X-Received: by 2002:a5d:59a7:: with SMTP id p7mr38613333wrr.258.1641222686962; Mon, 03 Jan 2022 07:11:26 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:b2ab:8f2a:6c31:735c]) by smtp.gmail.com with ESMTPSA id c2sm38963128wri.50.2022.01.03.07.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jan 2022 07:11:26 -0800 (PST) In-Reply-To: <20211019025111.08E2521120@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Mon, 18 Oct 2021 22:51:10 -0400 (EDT)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::434 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=rpluim@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284056 Archived-At: >>>>> On Mon, 18 Oct 2021 22:51:10 -0400 (EDT), larsi@gnus.org (Lars Ingebr= igtsen) said: Lars> diff --git a/lisp/vc/cvs-status.el b/lisp/vc/cvs-status.el Lars> index 723f277..86b62eb 100644 Lars> --- a/lisp/vc/cvs-status.el Lars> +++ b/lisp/vc/cvs-status.el Lars> @@ -35,7 +35,7 @@ Lars> ;;; =20 Lars> (defvar-keymap cvs-status-mode-map Lars> - :inherit 'cvs-mode-map Lars> + :parent 'cvs-mode-map Lars> "n" #'next-line Lars> "p" #'previous-line Lars> "N" #'cvs-status-next Shouldn't this be :parent cvs-mode-map (without the quote). I guess emacs-28 needs a similar fix (although I haven't noticed any negative side effects of it, but then again I don=CA=BCt use CVS at all) Robert --=20