unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Subject: next-error-last-buffer
Date: Sun, 09 May 2004 03:44:31 +0300	[thread overview]
Message-ID: <871xluig40.fsf@mail.jurta.org> (raw)

The current treatment of the `next-error-last-buffer' variable
is very inconvenient, because it is not possible to continue
visiting source files from a compilation other than the latest
compilation.

I think that `next-error-last-buffer' should be set buffer-locally
in the compilation buffer as well as in every source file visited
from that compilation buffer.  Thus calling `next-error' on a
visited buffer or a compilation buffer will continue visiting
locations for the same compilation from which a visited buffer
was found or a compilation buffer was created.

Index: lisp/simple.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/simple.el,v
retrieving revision 1.642
diff -u -r1.642 simple.el
--- lisp/simple.el	7 May 2004 22:31:54 -0000	1.642
+++ lisp/simple.el	9 May 2004 00:38:21 -0000
@@ -152,10 +152,12 @@
 \`compilation-error-regexp-alist' for customization ideas."
   (interactive "P")
   (if (consp arg) (setq reset t arg nil))
-  (when (setq next-error-last-buffer (next-error-find-buffer))
+  (when (setq-default next-error-last-buffer (next-error-find-buffer))
     ;; we know here that next-error-function is a valid symbol we can funcall
     (with-current-buffer next-error-last-buffer
-      (funcall next-error-function (prefix-numeric-value arg) reset))))
+      (set (make-local-variable 'next-error-last-buffer) next-error-last-buffer)
+      (funcall next-error-function (prefix-numeric-value arg) reset)
+      (set (make-local-variable 'next-error-last-buffer) next-error-last-buffer))))
 
 (defalias 'goto-next-locus 'next-error)
 (defalias 'next-match 'next-error)

-- 
Juri Linkov
http://www.jurta.org/emacs/

             reply	other threads:[~2004-05-09  0:44 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-09  0:44 Juri Linkov [this message]
2004-05-09 18:47 ` next-error-last-buffer Richard Stallman
2004-05-09 23:32   ` next-error-last-buffer Juri Linkov
2004-05-10 17:54     ` next-error-last-buffer Richard Stallman
2004-05-10 18:28       ` next-error-last-buffer Stefan Monnier
2004-05-10 23:45         ` next-error-last-buffer Juri Linkov
2004-05-11 12:23           ` next-error-last-buffer Richard Stallman
2004-05-10 23:35       ` next-error-last-buffer Juri Linkov
2004-05-11  2:19         ` next-error-last-buffer Stefan Monnier
2004-05-11 15:36         ` next-error-last-buffer Ted Zlatanov
2004-05-11 23:46           ` next-error-last-buffer Juri Linkov
2004-05-12 13:50             ` next-error-last-buffer Ted Zlatanov
2004-05-13  4:15               ` next-error-last-buffer Juri Linkov
2004-05-13 13:01                 ` next-error-last-buffer Ted Zlatanov
2004-05-12 19:42             ` next-error-last-buffer Richard Stallman
2004-05-13  4:23               ` next-error-last-buffer Juri Linkov
2004-05-13  4:57                 ` next-error-last-buffer Miles Bader
2004-05-13  5:17                   ` next-error-last-buffer Stefan Monnier
2004-05-13  5:34                   ` next-error-last-buffer Juri Linkov
2004-05-13  7:28                     ` next-error-last-buffer Miles Bader
2004-05-13 12:54               ` next-error-last-buffer Ted Zlatanov
2004-05-14  9:21                 ` next-error-last-buffer Richard Stallman
2004-05-14 14:58                   ` next-error-last-buffer Ted Zlatanov
2004-05-15  8:21                     ` next-error-last-buffer Juri Linkov
2004-05-15 18:34                       ` next-error-last-buffer Richard Stallman
2004-05-15  8:53                     ` next-error-last-buffer Richard Stallman
2004-05-24  8:46 ` next-error-last-buffer Juri Linkov
2004-05-24 14:16   ` next-error-last-buffer Ted Zlatanov
2004-05-25 20:09     ` next-error-last-buffer Juri Linkov
2004-05-26 13:49       ` next-error-last-buffer Ted Zlatanov
2004-05-27 12:46       ` next-error-last-buffer Richard Stallman
2004-05-28 15:38         ` next-error-last-buffer Ted Zlatanov
2004-05-28 21:07           ` next-error-last-buffer Juri Linkov
2004-05-29  3:47             ` next-error-last-buffer Ted Zlatanov
2004-05-30 14:30               ` next-error-last-buffer Richard Stallman
2004-06-01 17:41                 ` next-error-last-buffer Ted Zlatanov
2004-06-01 17:57                   ` next-error-last-buffer Ted Zlatanov
2004-06-02 17:36                     ` next-error-last-buffer Richard Stallman
2004-06-03 15:21                       ` next-error-last-buffer Ted Zlatanov
2004-06-04  2:03                         ` next-error-last-buffer Richard Stallman
2004-06-07 16:18                           ` next-error-last-buffer Ted Zlatanov
2004-06-08 20:31                             ` next-error-last-buffer Richard Stallman
2004-06-30 18:38                               ` next-error-last-buffer Ted Zlatanov
2004-07-01 17:14                                 ` next-error-last-buffer Richard Stallman
2004-05-25 16:06   ` next-error-last-buffer Richard Stallman
2004-05-25 20:14     ` next-error-last-buffer Juri Linkov
2004-05-26 13:56       ` next-error-last-buffer Ted Zlatanov
2004-05-27 21:55         ` next-error-last-buffer Juri Linkov
2004-05-27 23:53         ` next-error-last-buffer Richard Stallman
2004-05-28 15:29           ` next-error-last-buffer Stefan Monnier
2004-05-28 21:55             ` next-error-last-buffer Juri Linkov
2004-05-29  3:35             ` next-error-last-buffer Ted Zlatanov
2004-05-29 17:03             ` next-error-last-buffer Richard Stallman
2004-05-25 20:22 ` next-error-last-buffer Juri Linkov
2004-05-29  1:44   ` next-error-last-buffer Richard Stallman
2004-05-29 23:10     ` next-error-last-buffer Kim F. Storm
2004-05-30 19:41       ` next-error-last-buffer Richard Stallman
2004-05-31  6:39         ` next-error-last-buffer Werner LEMBERG
2004-05-31  7:20           ` next-error-last-buffer Juanma Barranquero
2004-06-01 17:52     ` next-error-last-buffer Ted Zlatanov
2004-06-01 21:33       ` next-error-last-buffer Kim F. Storm
2004-06-02 17:36       ` next-error-last-buffer Richard Stallman
2004-06-03 23:42     ` next-error-last-buffer Juri Linkov
2004-06-05 13:48       ` next-error-last-buffer Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871xluig40.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).