unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* safe-get
@ 2005-04-20 21:42 Richard Stallman
  2005-04-20 23:52 ` safe-get Stefan Monnier
  2005-04-21  8:09 ` safe-get Kim F. Storm
  0 siblings, 2 replies; 6+ messages in thread
From: Richard Stallman @ 2005-04-20 21:42 UTC (permalink / raw)
  Cc: emacs-devel

Is there a reason not to make ordinary `get' safe?  That would be
simpler for Lisp programmers than introducing safe-get.
The code would be simpler, the manual would be simpler, even
etc/NEWS would be simpler.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: safe-get
  2005-04-20 21:42 safe-get Richard Stallman
@ 2005-04-20 23:52 ` Stefan Monnier
  2005-04-21 19:56   ` safe-get Richard Stallman
  2005-04-21  8:09 ` safe-get Kim F. Storm
  1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2005-04-20 23:52 UTC (permalink / raw)
  Cc: emacs-devel, Kim F.Storm

> Is there a reason not to make ordinary `get' safe?  That would be
> simpler for Lisp programmers than introducing safe-get.
> The code would be simpler, the manual would be simpler, even
> etc/NEWS would be simpler.

Agreed.  Same thing for safe-plist-get.
BTW, XEmacs has overloaded `get' so that when applied to an overlay it does
overlay-get, ...


        Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: safe-get
  2005-04-20 21:42 safe-get Richard Stallman
  2005-04-20 23:52 ` safe-get Stefan Monnier
@ 2005-04-21  8:09 ` Kim F. Storm
  2005-04-21 19:56   ` safe-get Richard Stallman
  1 sibling, 1 reply; 6+ messages in thread
From: Kim F. Storm @ 2005-04-21  8:09 UTC (permalink / raw)
  Cc: emacs-devel

Richard Stallman <rms@gnu.org> writes:

> Is there a reason not to make ordinary `get' safe?  

Not really, except
a) it will not catch errors in the symbol plist.
b) it is slightly slower

>                                                     That would be
> simpler for Lisp programmers than introducing safe-get.
> The code would be simpler, the manual would be simpler, even
> etc/NEWS would be simpler.


I will revert my changes, and just make get safe...

But then, why don't we make plist-get safe
and get rid of safe-plist-get, too ?

IIRC, safe-plist-get is new in 22.1, so I don't see any big
problems doing that...

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: safe-get
  2005-04-21  8:09 ` safe-get Kim F. Storm
@ 2005-04-21 19:56   ` Richard Stallman
  2005-04-21 23:47     ` safe-get Kim F. Storm
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2005-04-21 19:56 UTC (permalink / raw)
  Cc: emacs-devel

    Not really, except
    a) it will not catch errors in the symbol plist.

That's not a drawback.

    b) it is slightly slower

That's a slight drawback, but probably not significant.

    I will revert my changes, and just make get safe...

Good.

    But then, why don't we make plist-get safe
    and get rid of safe-plist-get, too ?

Yes, we may as well.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: safe-get
  2005-04-20 23:52 ` safe-get Stefan Monnier
@ 2005-04-21 19:56   ` Richard Stallman
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2005-04-21 19:56 UTC (permalink / raw)
  Cc: emacs-devel, storm

    BTW, XEmacs has overloaded `get' so that when applied to an overlay it does
    overlay-get, ...

I see no possible harm in that, so we may as well be compatible.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: safe-get
  2005-04-21 19:56   ` safe-get Richard Stallman
@ 2005-04-21 23:47     ` Kim F. Storm
  0 siblings, 0 replies; 6+ messages in thread
From: Kim F. Storm @ 2005-04-21 23:47 UTC (permalink / raw)
  Cc: emacs-devel

Richard Stallman <rms@gnu.org> writes:

>     I will revert my changes, and just make get safe...
>
> Good.

Done.

>
>     But then, why don't we make plist-get safe
>     and get rid of safe-plist-get, too ?
>
> Yes, we may as well.

Done.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-04-21 23:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-20 21:42 safe-get Richard Stallman
2005-04-20 23:52 ` safe-get Stefan Monnier
2005-04-21 19:56   ` safe-get Richard Stallman
2005-04-21  8:09 ` safe-get Kim F. Storm
2005-04-21 19:56   ` safe-get Richard Stallman
2005-04-21 23:47     ` safe-get Kim F. Storm

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).