Tips to suppress compilation warnings

Tips to suppress compilation warnings

[Bill Wohler]

I'm seeing the following compiler warning:

  mh-customize.el:2462:1:Warning: the function `Info-goto-node' might not be
      defined at runtime.

Line 2462 is the last line.

Here is the function that yields the warning:

  (defun mh-tool-bar-letter-help ()
    "Visit \"(mh-e)Draft Editing\"."
    (interactive)
    (Info-goto-node "(mh-e)Draft Editing")
    (delete-other-windows))

However, I have this near the top of the file:

  (autoload 'Info-goto-node "info")

I don't see this warning under Emacs 21.4.

What is needed under CVS Emacs to fix this warning? (Besides (require
'info) which seems like an awfully big stick.)

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

Re: Tips to suppress compilation warnings

[Richard Stallman]

      mh-customize.el:2462:1:Warning: the function `Info-goto-node' might not be
	  defined at runtime.

    However, I have this near the top of the file:

      (autoload 'Info-goto-node "info")

It seems to me that this is a compiler bug.  That call to autoload,
being in this file, should prevent the warning.

However, if Info-goto-node is a useful thing to use from outside Info,
perhaps it should be defined as autoloaded in info.el rather than in mh-e.


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005

Re: Tips to suppress compilation warnings

[Stefan Monnier]

> However, if Info-goto-node is a useful thing to use from outside Info,
> perhaps it should be defined as autoloaded in info.el rather than in mh-e.

No.  Elisp packages that want to invoke info this way should use the `info'
function, which can be called just the same: (info "(mh-e)Draft Editing").


        Stefan


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005

Re: Tips to suppress compilation warnings

[Bill Wohler]

Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > However, if Info-goto-node is a useful thing to use from outside Info,
> > perhaps it should be defined as autoloaded in info.el rather than in mh-e.
> 
> No.  Elisp packages that want to invoke info this way should use the `info'
> function, which can be called just the same: (info "(mh-e)Draft Editing").

Stefan,

Thanks very much. Replacing Info-goto-node with info did the trick!

I used this information to solve the following in a similar fashion:

  mh-seq.el:1719:1:Warning: the function `view-mode' might not be defined at
      runtime.

RFTM revealed that we should be using view-mode-enter instead.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005

Re: Tips to suppress compilation warnings

[Jay Belanger]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> However, if Info-goto-node is a useful thing to use from outside Info,
>> perhaps it should be defined as autoloaded in info.el rather than in mh-e.
>
> No.  Elisp packages that want to invoke info this way should use the `info'
> function, which can be called just the same: (info "(mh-e)Draft Editing").

Info-goto-node is already autoloaded in info.el.
(This looks recent.)

Re: Tips to suppress compilation warnings

[Juri Linkov]

>>> However, if Info-goto-node is a useful thing to use from outside Info,
>>> perhaps it should be defined as autoloaded in info.el rather than in mh-e.
>>
>> No.  Elisp packages that want to invoke info this way should use the `info'
>> function, which can be called just the same: (info "(mh-e)Draft Editing").
>
> Info-goto-node is already autoloaded in info.el.

I wonder why there is the warning in mh-customize.el if Info-goto-node
currently has an autoload cookie in info.el?

> (This looks recent.)

autoload for Info-goto-node was added in info.el to avoid errors in
packages that don't call (require info) and don't autoload Info-goto-node
before calling Info-goto-node.

If `info' is the preferred method instead of `Info-goto-node',
autoload could be removed from info.el after replacing `Info-goto-node'
with `info' in all places in Emacs source code and mentioning the preferred
method in the NEWS file and Info documentation.

-- 
Juri Linkov
http://www.jurta.org/emacs/