From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates
Date: Sun, 21 Feb 2021 14:11:05 +0000 [thread overview]
Message-ID: <871rd9mrye.fsf@tcd.ie> (raw)
In-Reply-To: <874ki5lfyl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 14:15:30 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> This is the only declare form property that doesn't quote its value,
>> resulting in forms like (declare (completion 'foo)) rather than the more
>> conventional (declare (completion foo)). How's the following fix?
>
> But you can say
>
> (declare (completion (lambda (...) ...)))
Which my patch will turn into (function (lambda (...) ...)), which is
still correct and should be equivalent.
> So it's a list of functions, not a list of symbols...
What is a list? The completion-predicate property takes on a single
value satisfying functionp.
Both lambdas and symbols can be functions; my patch treats both equally,
so I see it as the correct treatment of this declare form property. If
you don't, then please elaborate on why not.
Thanks,
--
Basil
next prev parent reply other threads:[~2021-02-21 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210214131500.30678.63538@vcs0.savannah.gnu.org>
[not found] ` <20210214131502.DADCE20DFB@vcs0.savannah.gnu.org>
2021-02-20 19:30 ` master 9291e73 02/12: Add new 'declare' forms for command completion predicates Basil L. Contovounesios
2021-02-21 13:15 ` Lars Ingebrigtsen
2021-02-21 14:11 ` Basil L. Contovounesios [this message]
2021-02-21 15:54 ` Lars Ingebrigtsen
2021-02-21 16:13 ` Basil L. Contovounesios
2021-02-21 18:30 ` Lars Ingebrigtsen
2021-02-26 11:34 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rd9mrye.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).