unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates
Date: Fri, 26 Feb 2021 11:34:23 +0000	[thread overview]
Message-ID: <87lfbb12rk.fsf@tcd.ie> (raw)
In-Reply-To: <87r1l9gtni.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 19:30:57 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Why should explicit #'-quoting be needed for (declare (completion foo))
>> when it's not needed for any other declare form property, including the
>> new and related 'modes' property:
>>
>>   (declare (modes foo))
>>   (declare (gv-setter foo))
>>   (declare (gv-expander foo))
>>   (declare (obsolete foo ...))
>>   (declare (interactive-only foo))
>>   (declare (compiler-macro foo))
>>   (declare (indent foo))
>>
>> How is (declare (completion ...)) any different to these?
>
> Most of those refer to symbols (or numbers), so #'-ing is irrelevant.
> But gv-setter (for one) does refer to a function, so there's precedence
> for using symbols instead of functions here indeed.
>
> Anybody else have an opinion?

It seems there were no objections, so I applied the patch.

Function-quote completion property of declare form
752278834b 2021-02-26 11:26:22 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=752278834b3d317a65135cdaa392b0468ce7372c

Thanks,

-- 
Basil



      reply	other threads:[~2021-02-26 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210214131500.30678.63538@vcs0.savannah.gnu.org>
     [not found] ` <20210214131502.DADCE20DFB@vcs0.savannah.gnu.org>
2021-02-20 19:30   ` master 9291e73 02/12: Add new 'declare' forms for command completion predicates Basil L. Contovounesios
2021-02-21 13:15     ` Lars Ingebrigtsen
2021-02-21 14:11       ` Basil L. Contovounesios
2021-02-21 15:54         ` Lars Ingebrigtsen
2021-02-21 16:13           ` Basil L. Contovounesios
2021-02-21 18:30             ` Lars Ingebrigtsen
2021-02-26 11:34               ` Basil L. Contovounesios [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfbb12rk.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).