From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates Date: Sun, 21 Feb 2021 14:11:05 +0000 Message-ID: <871rd9mrye.fsf@tcd.ie> References: <20210214131500.30678.63538@vcs0.savannah.gnu.org> <20210214131502.DADCE20DFB@vcs0.savannah.gnu.org> <874ki6v8ob.fsf@tcd.ie> <874ki5lfyl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 21 15:12:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpSq-0008W1-7g for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Feb 2021 15:12:00 +0100 Original-Received: from localhost ([::1]:42590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDpSp-0000MM-7G for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Feb 2021 09:11:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDpS4-0008Ep-O5 for emacs-devel@gnu.org; Sun, 21 Feb 2021 09:11:13 -0500 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDpS3-0000Tt-1b for emacs-devel@gnu.org; Sun, 21 Feb 2021 09:11:12 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id h98so11487530wrh.11 for ; Sun, 21 Feb 2021 06:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8medtjlqAwQckA2XU1FwOS4/nrK5Lrm5S8FP9bhpgBE=; b=Aabj+iT8xzILWoPXGDGvA+SpCKMLvuEiUvLtO2af3l15CdtlxGh2IdwlC168u1Wdg9 6Wb88kpGbOeW1lgYlQJpQZvrDQKSv4+mYGA4doAXYWgJH5327655c272aPFPU0n3RARD GgdB328Opab/J/hWfnm/1RRjx27Mv57TeaNSWOI6P56KGLdLEzK6gMG3BlsYFvzzjFDk NUvlhAN9RMYrorJXUosW01SgBfDUjpbBUYrB5za7unQhvPZQQpryfNeRed0qCLeeGqK1 Md+j4KyKMsW0/C8bTKTskuSuO1FZ38TUVddruDQ1XZwHTIySBJDtsJhQPhIhSnmKeNi8 rgQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8medtjlqAwQckA2XU1FwOS4/nrK5Lrm5S8FP9bhpgBE=; b=HL0syMVwOOvHqhTSD0CvYwT4kcugv0I7FdVLEb2QvQ7E7jFeVHokAd/o1x7lEv+DjM IwQusPjKR2ihJW2Eq3+lpJNJwKC/8o+VutQxc+6BE2g8GDMMPr1dCaGOaFaj2RXQy9Am 8YQf1tIRr8lRyzwgC8QImm+e10usSlCFhYb9O8ynIEHdVAQpuuyvx131q/kuaJUp1boj 5o/hmzN09mrPqO3JEO6yJzwiS3xCHuUMrpAalYltRToTW0QI3EZkwP30a5nix4deePsA e6ohNiUoH6EPXjGYDdeNt4z0a7XhLhXBtzRydCupLwbT4Qhq2ya/6gvAF9iVaow3Viue tcoA== X-Gm-Message-State: AOAM531x+I32D5BgBZmavxdSuNiTxLCjqfMH1YIjTFqWlBJsfTFhx3Nw KnTyDb5QNX2Z0k5UNESV4cpYGw== X-Google-Smtp-Source: ABdhPJz4BVM0wjwgvQTHNYEAjt8HRD1pYZMkyGmaS4eZtT47VAR4tAIDX5jQKHB0RraOT24F0gayPQ== X-Received: by 2002:a5d:6a4f:: with SMTP id t15mr755696wrw.219.1613916667692; Sun, 21 Feb 2021 06:11:07 -0800 (PST) Original-Received: from localhost ([51.37.47.108]) by smtp.gmail.com with ESMTPSA id 36sm25992924wrj.97.2021.02.21.06.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:11:07 -0800 (PST) In-Reply-To: <874ki5lfyl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 14:15:30 +0100") Received-SPF: none client-ip=2a00:1450:4864:20::431; envelope-from=contovob@tcd.ie; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265387 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> This is the only declare form property that doesn't quote its value, >> resulting in forms like (declare (completion 'foo)) rather than the more >> conventional (declare (completion foo)). How's the following fix? > > But you can say > > (declare (completion (lambda (...) ...))) Which my patch will turn into (function (lambda (...) ...)), which is still correct and should be equivalent. > So it's a list of functions, not a list of symbols... What is a list? The completion-predicate property takes on a single value satisfying functionp. Both lambdas and symbols can be functions; my patch treats both equally, so I see it as the correct treatment of this declare form property. If you don't, then please elaborate on why not. Thanks, -- Basil