From: Amin Bandali <bandali@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
emacs-erc@gnu.org, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: ERC
Date: Tue, 28 Sep 2021 21:40:57 -0400 [thread overview]
Message-ID: <871r58p39y.fsf@gnu.org> (raw)
In-Reply-To: <jwvo88dremu.fsf-monnier+emacs@gnu.org>
Stefan Monnier writes:
>>> The way you're suggesting to do it, `erc-autoloads.el` will end up
>>> defining/autoloading a lot more "stuff" even when ERC is not
>>> used/loaded. Maybe it's not terribly important, but I think it's
>>> important to be aware of the difference.
>>
>> Thanks for pointing this out. Admittedly, my understanding of the
>> autoload machinery is somewhat lacking. Would you please elaborate
>> more on this?
>
> I think I was just confused. I thought ERC used a similar mechanism to
> the one used by MH-E and Tramp (where they use special lisp/Makefile
> rules to generate their <pkg>-loaddefs.el files).
>
>
> Stefan
>
>
Oh, indeed. Here's the commit that introduced erc-loaddefs.el:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=95369ac346d75a7b75bc2c5adf632cc4faa1241a
It just set the `generated-autoload-file' file local variable to
"erc-loaddefs.el" in erc*.el.
So I suppose it's fine as is, and I could proceed with my initially
proposed patches.
My only question at this point is, would the recent change to GNU ELPA
machinery where it pulls the exact commit changing the Version apply
for a new addition like ERC as well? Does that mean adding ERC right
now would take it from this commit?
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fa778b62c936d5d3a3cc348043c072d7011f13f
--
https://bndl.org
next prev parent reply other threads:[~2021-09-29 1:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 17:03 [ELPA] New package: ERC Amin Bandali
2021-09-19 14:38 ` Lars Ingebrigtsen
2021-09-26 15:22 ` Amin Bandali
2021-09-26 19:28 ` Philip Kaludercic
2021-09-26 20:41 ` Amin Bandali
2021-09-27 10:22 ` Philip Kaludercic
2021-09-28 2:36 ` Amin Bandali
2021-09-26 20:15 ` Stefan Kangas
2021-09-26 21:03 ` Amin Bandali
2021-09-27 10:23 ` Philip Kaludercic
2021-09-29 1:26 ` Amin Bandali
2021-09-27 19:42 ` Stefan Monnier
2021-09-29 1:40 ` Amin Bandali [this message]
2021-09-29 3:30 ` Stefan Monnier
2021-09-29 4:11 ` Amin Bandali
2021-09-20 16:48 ` Stefan Monnier
2021-09-21 0:16 ` Emanuel Berg via General discussion about ERC
2021-09-21 5:31 ` Corwin Brust
2021-09-21 7:12 ` Emanuel Berg via General discussion about ERC
2021-09-21 23:56 ` Amin Bandali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r58p39y.fsf@gnu.org \
--to=bandali@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-erc@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).