From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.erc.general,gmane.emacs.devel Subject: Re: [ELPA] New package: ERC Date: Tue, 28 Sep 2021 21:40:57 -0400 Message-ID: <871r58p39y.fsf@gnu.org> References: <87tuih3jfq.fsf@gnu.org> <875yuwpr4o.fsf@gnus.org> <87o88f746a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-erc@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Wed Sep 29 03:41:08 2021 Return-path: Envelope-to: sf-erc-help@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVOao-0003KN-9P for sf-erc-help@m.gmane-mx.org; Wed, 29 Sep 2021 03:41:06 +0200 Original-Received: from localhost ([::1]:56620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVOan-0006V1-9I for sf-erc-help@m.gmane-mx.org; Tue, 28 Sep 2021 21:41:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVOal-0006UO-44; Tue, 28 Sep 2021 21:41:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38594) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVOaj-0000pm-LF; Tue, 28 Sep 2021 21:41:01 -0400 Original-Received: from [2607:fea8:3fdf:f2d9:c5b3:57be:c5c0:60dd] (port=40172 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVOag-00006u-NJ; Tue, 28 Sep 2021 21:41:01 -0400 In-Reply-To: X-BeenThere: emacs-erc@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: General discussion about ERC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Original-Sender: "emacs-erc" Xref: news.gmane.io gmane.emacs.erc.general:1610 gmane.emacs.devel:275751 Archived-At: Stefan Monnier writes: >>> The way you're suggesting to do it, `erc-autoloads.el` will end up >>> defining/autoloading a lot more "stuff" even when ERC is not >>> used/loaded. Maybe it's not terribly important, but I think it's >>> important to be aware of the difference. >> >> Thanks for pointing this out. Admittedly, my understanding of the >> autoload machinery is somewhat lacking. Would you please elaborate >> more on this? > > I think I was just confused. I thought ERC used a similar mechanism to > the one used by MH-E and Tramp (where they use special lisp/Makefile > rules to generate their -loaddefs.el files). > > > Stefan > > Oh, indeed. Here's the commit that introduced erc-loaddefs.el: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=95369ac346d75a7b75bc2c5adf632cc4faa1241a It just set the `generated-autoload-file' file local variable to "erc-loaddefs.el" in erc*.el. So I suppose it's fine as is, and I could proceed with my initially proposed patches. My only question at this point is, would the recent change to GNU ELPA machinery where it pulls the exact commit changing the Version apply for a new addition like ERC as well? Does that mean adding ERC right now would take it from this commit? https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fa778b62c936d5d3a3cc348043c072d7011f13f -- https://bndl.org