From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: eglot--spinner Date: Fri, 18 Nov 2022 00:27:39 -0800 Message-ID: <86r0y07jlw.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 18 09:28:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovwjt-0003ME-Ir for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Nov 2022 09:28:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovwjE-0008UD-Ut; Fri, 18 Nov 2022 03:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovwjD-0008RX-68 for emacs-devel@gnu.org; Fri, 18 Nov 2022 03:28:03 -0500 Original-Received: from outbound-ss-820.bluehost.com ([69.89.24.241]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovwjB-0006Zs-3V for emacs-devel@gnu.org; Fri, 18 Nov 2022 03:28:02 -0500 Original-Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 2D3BB10048175 for ; Fri, 18 Nov 2022 08:27:43 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id vwiqo3tVcbFxbvwiqo3pxO; Fri, 18 Nov 2022 08:27:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=D72Cltdj c=1 sm=1 tr=0 ts=637741ff a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=ACK5m62oBU5ZE_mG0foA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FoJysLoJ7Hgy5AU9OI5p4tMptBwLZJg5jtGIEDLsnLQ=; b=NkcpSVEjuXe1Jz2Ydr81Jt+/iN 200GXvdw+yQtoj4nP4ah0K2s/XrC7ZqmLb4jUFCZFMoJ7XgenCt4FFqECluVZI3rh9G59kIDqqfC1 AQjCbs/FOoTUsFDgGfG6APnPqoq53/HFsaxEy5sXGLNYZ8Gud6yav0VXGjvPBZwIbx3QsPIXHccxn vlK1c3RQwoAv5rBQ65d8RWZz42sBWy5OQhsN3yiXO+PyyrC04W5sawSo3k86eidRf/z4H+9VvPB0D CG2yo+1Im/HxhLGN2CuzWETr/DxSU+ZyOCZH+16NuQDzqer4/DgEdgmvf9G/rRQ6ASgt8U+mQmWzP 0QPFD0jg==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:57176 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovwiq-003QSj-F5; Fri, 18 Nov 2022 01:27:40 -0700 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1ovwiq-003QSj-F5 X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:57176 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=69.89.24.241; envelope-from=stephen_leake@stephe-leake.org; helo=outbound-ss-820.bluehost.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300097 Archived-At: The only uses of eglot--spinner in eglot.el are: eglot--mode-line-format, where it is added to the mode line. eglot--signal-textDocument/didChange, where it is set to (list nil :textDocument/didChange t), meaning didChange is done. Because this is set to done, it is not actually displayed in the modeline. For ada-mode, I'd like to use eglot--spinner to show "indexing" progress; the server is parsing all the files in the project, collecting cross reference information, which takes a while. The user needs to know when it is done; then they can use cross reference commands. So I'd like to delete setting eglot--spinner in eglot--signal-textDocument/didChange; otherwise that will overwrite the indexing progress when a buffer is edited. This would also imply making eglot--spinner public. That then raises the issue of future conflicting uses of eglot-spinner. So perhaps it would be better for ada-mode to add another item to the mode line? To do that requires a hook in eglot--mode-line-format, so it is grouped with the other eglot-derived mode line items. -- -- Stephe