From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>,
Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Cc: Juri Linkov <juri@linkov.net>, emacs-devel@gnu.org
Subject: Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.]
Date: Thu, 7 Jan 2021 15:41:28 +0000 (UTC) [thread overview]
Message-ID: <86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default> (raw)
> This change causes a byte-compilation warning:
> In toplevel form:
> mb-depth.el:38:1: Warning: defface for
> `minibuffer-depth-indicator' fails to specify
> containing group
IMHO, we should adopt and promote a guideline
that it's a good, not a bad, idea to always
include an explicit `:group'.
I think that Stefan is quite opposed to this,
and he even goes to the trouble of removing
"unnecessary" `:group's. Why?
AFAIK, the only advantage to omitting `:group'
is a little less verbose code.
The advantages to _not_ omitting `:group' are:
1. Local clarity - no need to look elsewhere.
2. Ability to move the thing elsewhere - its
behavior/meaning wrt :group won't depend on
its location.
To me, those advantages to not omitting `:group'
far outweigh the disadvantage. But please point
out any advantage of omitting `:group' that I
may have missed.
It's good that `:group' is optional. But it's
also good to get in the habit of not omitting
it, IMO, and that's a good practice to encourage.
next reply other threads:[~2021-01-07 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 15:41 Drew Adams [this message]
2021-01-07 15:54 ` Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.] Eli Zaretskii
[not found] <<86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default>
[not found] ` <<838s94lp35.fsf@gnu.org>
2021-01-07 16:18 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gabriel376@hotmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).