unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: gabriel376@hotmail.com, emacs-devel@gnu.org, juri@linkov.net
Subject: RE: Omitting :group    [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.]
Date: Thu, 7 Jan 2021 16:18:55 +0000 (UTC)	[thread overview]
Message-ID: <c613f274-b7dd-422b-9394-486d5d41223e@default> (raw)
In-Reply-To: <<838s94lp35.fsf@gnu.org>>

> > > This change causes a byte-compilation warning:
> > >   In toplevel form:
> > >   mb-depth.el:38:1: Warning: defface for
> > >   `minibuffer-depth-indicator' fails to specify
> > >   containing group
> >
> > IMHO, we should adopt and promote a guideline
> > that it's a good, not a bad, idea to always
> > include an explicit `:group'.
> 
> Aren't you confusing :group in defcustom with :group in defface?

Perhaps I am (am I)?  What's the difference?

(elisp) `Common Keywords' suggests that its
description of :group applies to "the next few
sections-'defcustom', 'defgroup', etc."

And node `Group Definitions' suggests that a
group defined by `defgroup' applies to all of
the group's members, and that such members are
declared using `:group'.

`:group' is specified for use in many constructs,
in many nodes of the Elisp manual.  Shouldn't its
behavior (and usage guidelines) be the same
everywhere?

FWIW, I don't see any special description of 
`:group' in the doc about `defface'.  I do see,
in other nodes, cross-references to nodes that
introduce/define customization groups - but I
don't see any such xref in the node for `defface'.



       reply	other threads:[~2021-01-07 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default>
     [not found] ` <<838s94lp35.fsf@gnu.org>
2021-01-07 16:18   ` Drew Adams [this message]
2021-01-07 15:41 Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.] Drew Adams
2021-01-07 15:54 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c613f274-b7dd-422b-9394-486d5d41223e@default \
    --to=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gabriel376@hotmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).