From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: Omitting :group [was: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.] Date: Thu, 7 Jan 2021 15:41:28 +0000 (UTC) Message-ID: <86c3f5d3-b2be-4573-a7a5-0c8d94c0d193@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36975"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , emacs-devel@gnu.org To: Eli Zaretskii , Gabriel do Nascimento Ribeiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 16:42:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxXQg-0009Tu-0G for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 16:42:26 +0100 Original-Received: from localhost ([::1]:53636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxXQf-0003Jj-22 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 10:42:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxXPw-0002u9-Ij for emacs-devel@gnu.org; Thu, 07 Jan 2021 10:41:41 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:47540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxXPs-0007sY-Gn; Thu, 07 Jan 2021 10:41:39 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107FdixG049401; Thu, 7 Jan 2021 15:41:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=nZGxv0mGVcJcQXwc21F2rMjOoLSOX8JLObvFO+32PbI=; b=Oo9/S3Q6ajY5SBwciufFDeOqzCF7qu7JqbRyNWJyBhKTAZRx3Uq46eJumXKEYPMHBqe1 8BGXToDFLKUntcHaU/qraM9h1MxRtF0GhrvqsnrdAdj35smzyrhFeSP3lyz/4TeBHR9w 2PeEEB+hCj6X7EmF52YeqiFGhTj9sum/wL1O0PjTHJSkWCNPfreC7VXxjrNyprjxfnO9 cRcqF3StmI7bf3A7FScNhKpgew57sYgbMWbbJOg5gNoGl7obawwiBHCSEf4p+BeGejG3 jnlcsWU6Ng/4aWuWrB2hakjDGNm3KDvWhMBO5sD3F9COxA/RcZwa2jRlCTdhII+Zwz9G Yw== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 35wepmcwgv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 07 Jan 2021 15:41:34 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 107FV8Dp045582; Thu, 7 Jan 2021 15:41:34 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 35v1fbd8gx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Jan 2021 15:41:34 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 107FfTXq023228; Thu, 7 Jan 2021 15:41:29 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9856 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070097 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9856 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101070097 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.246, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262689 Archived-At: > This change causes a byte-compilation warning: > In toplevel form: > mb-depth.el:38:1: Warning: defface for > `minibuffer-depth-indicator' fails to specify > containing group IMHO, we should adopt and promote a guideline that it's a good, not a bad, idea to always include an explicit `:group'. I think that Stefan is quite opposed to this, and he even goes to the trouble of removing "unnecessary" `:group's. Why? AFAIK, the only advantage to omitting `:group' is a little less verbose code. The advantages to _not_ omitting `:group' are: 1. Local clarity - no need to look elsewhere. 2. Ability to move the thing elsewhere - its behavior/meaning wrt :group won't depend on its location. To me, those advantages to not omitting `:group' far outweigh the disadvantage. But please point out any advantage of omitting `:group' that I may have missed. It's good that `:group' is optional. But it's also good to get in the habit of not omitting it, IMO, and that's a good practice to encourage.