From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org,Andy Moreton <andrewjmoreton@gmail.com>
Subject: Re: Replace XChar2b with unsigned in all font backends
Date: Tue, 21 May 2019 09:00:55 +0100 [thread overview]
Message-ID: <85C56B1B-2554-45AE-AC66-5DE3CEC6AC94@gnu.org> (raw)
In-Reply-To: <867eak4u35.fsf@gmail.com>
On May 20, 2019 11:52:30 PM GMT+01:00, Andy Moreton <andrewjmoreton@gmail.com> wrote:
> On Mon 20 May 2019, Eli Zaretskii wrote:
>
> > On May 20, 2019 7:29:34 PM GMT+01:00, Andy Moreton
> <andrewjmoreton@gmail.com> wrote:
> >> Please revert this patch to fix the build on master, and then
> revisit
> >> these changes after that.
> >>
> > You ask to revert because you don't think there's a way of fixing
> this without reverting? Or fof some other reason?
>
> The first order of business is to restore master to a usable state.
> After that, any amount of time can be taken to revise the non-working
> patch into something that does not cause the regression.
>
> "Don't break the build" is an important rule. A recent Rx patch was
> reverted by its author because it broke bootstrapping, and then a
> revised version added later after the problem with the original patch
> had been fixed. Why should this patch be any different ?
>
> AndyM
We are miscommunicating, I think. I didn't mean the problem shouldn't be resolved ASAP, I meant it should be resolved by fixing the fallout from that commit rather then by reverting it.
One way of fixing that is by copying values from array of unsigned int to array of unsigned short. Maybe there are others, I'm currently away of the sources and cannot say more.
next prev parent reply other threads:[~2019-05-21 8:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:26 Replace XChar2b with unsigned in all font backends martin rudalics
2019-05-20 12:05 ` Andy Moreton
2019-05-20 18:14 ` Alex Gramiak
2019-05-20 18:29 ` Andy Moreton
2019-05-20 19:20 ` Eli Zaretskii
2019-05-20 22:52 ` Andy Moreton
2019-05-21 8:00 ` Eli Zaretskii [this message]
2019-05-21 11:50 ` Andy Moreton
2019-05-21 12:38 ` Eli Zaretskii
2019-05-20 19:34 ` Alex Gramiak
2019-05-20 18:07 ` Alex Gramiak
2019-05-21 7:33 ` martin rudalics
2019-05-21 21:32 ` Alex Gramiak
2019-05-21 23:04 ` Andy Moreton
2019-05-22 8:30 ` martin rudalics
2019-05-21 11:47 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85C56B1B-2554-45AE-AC66-5DE3CEC6AC94@gnu.org \
--to=eliz@gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).