unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Replace XChar2b with unsigned in all font backends
Date: Tue, 21 May 2019 12:50:59 +0100	[thread overview]
Message-ID: <vz1blzw3u1o.fsf@gmail.com> (raw)
In-Reply-To: 85C56B1B-2554-45AE-AC66-5DE3CEC6AC94@gnu.org

On Tue 21 May 2019, Eli Zaretskii wrote:

> We are miscommunicating, I think. I didn't mean the problem shouldn't be
> resolved ASAP, I meant it should be resolved by fixing the fallout from that
> commit rather then by reverting it.

Indeed - the end goal is useful, but it seems we have different views on
how to get there. This patch has problems on Windows (described in this
thread), and on Linux (bug 35814).

Trying to fix it up in place will leave master broken for some time, so
I think an initial revert followed by reworking the patch in smaller
steps may be an easier way forward.

    AndyM





  reply	other threads:[~2019-05-21 11:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  8:26 Replace XChar2b with unsigned in all font backends martin rudalics
2019-05-20 12:05 ` Andy Moreton
2019-05-20 18:14   ` Alex Gramiak
2019-05-20 18:29     ` Andy Moreton
2019-05-20 19:20       ` Eli Zaretskii
2019-05-20 22:52         ` Andy Moreton
2019-05-21  8:00           ` Eli Zaretskii
2019-05-21 11:50             ` Andy Moreton [this message]
2019-05-21 12:38               ` Eli Zaretskii
2019-05-20 19:34       ` Alex Gramiak
2019-05-20 18:07 ` Alex Gramiak
2019-05-21  7:33   ` martin rudalics
2019-05-21 21:32     ` Alex Gramiak
2019-05-21 23:04       ` Andy Moreton
2019-05-22  8:30       ` martin rudalics
2019-05-21 11:47   ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vz1blzw3u1o.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).