From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace XChar2b with unsigned in all font backends Date: Tue, 21 May 2019 09:00:55 +0100 Message-ID: <85C56B1B-2554-45AE-AC66-5DE3CEC6AC94@gnu.org> References: <87v9y5uh63.fsf@gmail.com> <9A8FC3EE-ED24-49CC-8B13-294FF7F4D4BD@gnu.org> <867eak4u35.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184475"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android To: emacs-devel@gnu.org,Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 10:01:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSziS-000lrq-3d for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 10:01:44 +0200 Original-Received: from localhost ([127.0.0.1]:48496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSziQ-0006Wx-Ns for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 04:01:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSzhk-0006Wr-Tg for emacs-devel@gnu.org; Tue, 21 May 2019 04:01:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSzhj-00026V-3S; Tue, 21 May 2019 04:00:59 -0400 Original-Received: from [217.38.53.90] (port=40459 helo=[10.82.56.8]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hSzhg-0008EG-3G; Tue, 21 May 2019 04:00:57 -0400 In-Reply-To: <867eak4u35.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236844 Archived-At: On May 20, 2019 11:52:30 PM GMT+01:00, Andy Moreton wrote: > On Mon 20 May 2019, Eli Zaretskii wrote: >=20 > > On May 20, 2019 7:29:34 PM GMT+01:00, Andy Moreton > wrote: > >> Please revert this patch to fix the build on master, and then > revisit > >> these changes after that=2E > >>=20 > > You ask to revert because you don't think there's a way of fixing > this without reverting? Or fof some other reason? >=20 > The first order of business is to restore master to a usable state=2E > After that, any amount of time can be taken to revise the non-working > patch into something that does not cause the regression=2E >=20 > "Don't break the build" is an important rule=2E A recent Rx patch was > reverted by its author because it broke bootstrapping, and then a > revised version added later after the problem with the original patch > had been fixed=2E Why should this patch be any different ? >=20 > AndyM We are miscommunicating, I think=2E I didn't mean the problem shouldn't b= e resolved ASAP, I meant it should be resolved by fixing the fallout from t= hat commit rather then by reverting it=2E One way of fixing that is by copying values from array of unsigned int to = array of unsigned short=2E Maybe there are others, I'm currently away of t= he sources and cannot say more=2E