Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[John Wiegley]

>>>>> "VB" == Vincent Bela�che <vincentb1@users.sourceforge.net> writes:

VB> branch: emacs-25
VB> commit 8a38e948b039516e70176ebe20c5349e2ade6ac5
VB> Author: Vincent Belaïche <vincentb1@users.sourceforge.net>
VB> Commit: Vincent Belaïche <vincentb1@users.sourceforge.net>

VB>     Fix local printer set to left aligned string formatter.

VB>     * lisp/ses.el (ses-local-printer-compile): Add missing case for
VB>                   left-aligned string formatter.

Hello Vincent,

Can you please include which bug this is fixing, so that I may verify that it
was indeed on our release blocking list?  We're at RC1 now, so any change --
however small -- requires great scrutiny.

Alternatively, please link to the discussion thread where Eli gave the OK to
commit this to emacs-25.

Thanks!
-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

RE: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[Vincent Belaïche]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Dear John,


Well, I must admit that I am a naughty boy that has not filed any bug before making this fix. I of course did some basic tests before comitting and it was OK.


The bug description is as follows:


Using the ``string within round bracket'' kind of printer definition (round bracketing meaning left alignment) for a local printers does not work because the ses-local-printer-compile function does not handle this case.


IMHO taking this bug fix is not risky and that would make the local printer feature more complete. The alternative fix would be to document that in this release local printers cannot be defined this way, but it seems so simpler to fix the lisp than to obfuscate documentation...


   Vincent.


PS : I'll try to join this discussion thread which you mention when I can find it, sorry I have to go to bed now (tired)...

________________________________
De : Emacs-devel <emacs-devel-bounces+vincent.b.1=hotmail.fr@gnu.org> de la part de John Wiegley <jwiegley@gmail.com>
Envoyé : lundi 1 août 2016 18:26:50
À : emacs-devel@gnu.org
Cc : Vincent Belaïche
Objet : Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

>>>>> "VB" == Vincent Bela?che <vincentb1@users.sourceforge.net> writes:

VB> branch: emacs-25
VB> commit 8a38e948b039516e70176ebe20c5349e2ade6ac5
VB> Author: Vincent Belaïche <vincentb1@users.sourceforge.net>
VB> Commit: Vincent Belaïche <vincentb1@users.sourceforge.net>

VB>     Fix local printer set to left aligned string formatter.

VB>     * lisp/ses.el (ses-local-printer-compile): Add missing case for
VB>                   left-aligned string formatter.

Hello Vincent,

Can you please include which bug this is fixing, so that I may verify that it
was indeed on our release blocking list?  We're at RC1 now, so any change --
however small -- requires great scrutiny.

Alternatively, please link to the discussion thread where Eli gave the OK to
commit this to emacs-25.

Thanks!
--
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2


[-- Attachment #2: Type: text/html, Size: 3851 bytes --]

RE: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

Vincent Belaïche <vincent.b.1@hotmail.fr> writes:

> Well, I must admit that I am a naughty boy that has not filed any bug
> before making this fix. I of course did some basic tests before
> comitting and it was OK.

Hi Vincent,

The purpose of a release candidate is to provide a tarball as close as
possible to the final release for testing, so once the first RC is out,
only critical bug fixes should be pushed to the release branch.

If a particular bug is blocking the release, then it's of course ok to
commit a fix for it on emacs-25, but since it's not the case here, I
think that commits 8a38e94 and 3c97b0f should have been pushed to master
instead.

> IMHO taking this bug fix is not risky and that would make the local
> printer feature more complete.

I understand that, but who knows, even if your commit looks safe it
might still introduce issues that you haven't seen yet :-)

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[Vincent Belaïche]

Kenavo Nico,

Le 02/08/2016 à 00:48, Nicolas Petton a écrit :
> Vincent Belaïche <vincent.b.1@hotmail.fr> writes:
>
>> Well, I must admit that I am a naughty boy that has not filed any bug
>> before making this fix. I of course did some basic tests before
>> comitting and it was OK.
>
> Hi Vincent,
>
> The purpose of a release candidate is to provide a tarball as close as
> possible to the final release for testing, so once the first RC is
> out, only critical bug fixes should be pushed to the release branch.
>
> If a particular bug is blocking the release, then it's of course ok to
> commit a fix for it on emacs-25, but since it's not the case here,

Of course it is not a blocking bug. Without the correction you are just
prevented to configure a local printer using at the same time left
alignment and a string format specifier. Having said that, all the other
functions are OK AFAIK.

> I think that commits 8a38e94 and 3c97b0f should have been pushed to
> master instead.
>
>> IMHO taking this bug fix is not risky and that would make the local
>> printer feature more complete.
>
> I understand that, but who knows, even if your commit looks safe

It is only two lines of code, creating a new branch within a cond rather
than modifying any existing branch + I have made some tests. So yes, it
seems quite safe to take it.

> it might still introduce issues that you haven't seen yet :-)

That is correct, who knows... I has happened so many times to me in the
past that some correction makes some other problem appear.

Sometimes some bug is hidding some other bug by disabling some function,
and the program is more stable without the prior bug corrected.

So, I cannot tell the opposite: any change is a risk. I am not making a
fuss if people take the decision here not to take the correction in
emacs-25 even though would it depend only on me then I would take
it. This is *not* a critical correction and not being a frequent
contributor I just made the correction on emacs-25 without knowing it
was under release freeze because still this is a bug, not a new
function, and it has to be corrected anyhow.

BTW, is there any list with *LOW TRAFIC* on which release status
(freeze, etc...) is announced. Is the list info-gnu-emacs for that ? I
must say that I very seldom go on emacs-devel by lack of time.

>
> Cheers,
> Nico

À+,
  Vincent.


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[Stefan Monnier]

> This is *not* a critical correction and not being a frequent
> contributor I just made the correction on emacs-25 without knowing it

> BTW, is there any list with *LOW TRAFIC* on which release status
> (freeze, etc...) is announced. Is the list info-gnu-emacs for that ? I
> must say that I very seldom go on emacs-devel by lack of time.

I recommend anyone not actively following emacs-devel to only commit to
master, so as to avoid those problems.


        Stefan

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[John Wiegley]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

>>>>> Vincent Belaïche <vincent.b.1@hotmail.fr> writes:

> IMHO taking this bug fix is not risky and that would make the local printer
> feature more complete.

I'm sorry, Vincent, but I cannot take your assurance of this in light of the
fact that we recently issued a release candidate. I am reverting your changes,
but feel free to apply them to master.

The reason for having a release freeze is to not accept commits like this,
which have not been agreed upon by others as critical (needing to be fixed
NOW), and which have not been reviewed by anyone else. If everyone were to
commit whatever small fix they thought was safe, there would be no release.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[Vincent Belaïche]

Le 02/08/2016 à 20:44, John Wiegley a écrit :
>>>>>> Vincent Belaïche <vincent.b.1@hotmail.fr> writes:
>
>> IMHO taking this bug fix is not risky and that would make the local printer
>> feature more complete.
>
> I'm sorry, Vincent, but I cannot take your assurance of this in light of the
> fact that we recently issued a release candidate. I am reverting your changes,
> but feel free to apply them to master.

Done.

>
> The reason for having a release freeze is to not accept commits like this,
> which have not been agreed upon by others as critical (needing to be fixed
> NOW), and which have not been reviewed by anyone else. If everyone were to
> commit whatever small fix they thought was safe, there would be no release.
>

I agree, no need to be sorry :-). As I had written in my previous email
I do not follow the emacs-devel list anyhow closely by lack of time. And
I am not aware of another list with _low_ traffic to make that sort of
announcement that a branch is in release freeze. That is why this is not
the first time that I do this "non critical correction on release-frozen
branch" mistake.

VBR,
	Vincent.

---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

[John Wiegley]

>>>>> Vincent Belaïche <vincent.belaiche@gmail.com> writes:

> I am not aware of another list with _low_ traffic to make that sort of
> announcement that a branch is in release freeze.

The emacs-devel list supports an "announce" tag that you can enable, so that
you only receive messages marked as announcements to the developers.  Now I
just need to start using it... :)

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2