From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?iso-8859-9?Q?Vincent_Bela=EFche?= Newsgroups: gmane.emacs.devel Subject: RE: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter. Date: Mon, 1 Aug 2016 22:03:29 +0000 Message-ID: References: <20160728174955.13840.3558@vcs.savannah.gnu.org> <20160728174955.752F622016B@vcs.savannah.gnu.org>, NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_AM5PR10MB0676FA23F7CE8A0AC008998984040AM5PR10MB0676EURP_" X-Trace: blaine.gmane.org 1470090240 11964 195.159.176.226 (1 Aug 2016 22:24:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Aug 2016 22:24:00 +0000 (UTC) Cc: =?iso-8859-9?Q?Vincent_Bela=EFche?= To: John Wiegley , "emacs-devel@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 02 00:23:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bULco-0002lf-Lm for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 00:23:54 +0200 Original-Received: from localhost ([::1]:53072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bULcl-0006Jw-5X for ged-emacs-devel@m.gmane.org; Mon, 01 Aug 2016 18:23:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bULcb-0006Jb-Hb for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:23:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bULcX-0008Lc-8K for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:23:40 -0400 Original-Received: from col004-omc4s10.hotmail.com ([65.55.34.212]:61106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bULcW-0008LE-TL for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:23:37 -0400 Original-Received: from EUR01-HE1-obe.outbound.protection.outlook.com ([65.55.34.201]) by COL004-OMC4S10.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 1 Aug 2016 15:03:33 -0700 Original-Received: from HE1EUR01FT003.eop-EUR01.prod.protection.outlook.com (10.152.0.59) by HE1EUR01HT063.eop-EUR01.prod.protection.outlook.com (10.152.0.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8; Mon, 1 Aug 2016 22:03:31 +0000 Original-Received: from AM5PR10MB0676.EURPRD10.PROD.OUTLOOK.COM (10.152.0.58) by HE1EUR01FT003.mail.protection.outlook.com (10.152.0.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.557.8 via Frontend Transport; Mon, 1 Aug 2016 22:03:31 +0000 Original-Received: from AM5PR10MB0676.EURPRD10.PROD.OUTLOOK.COM ([10.167.221.144]) by AM5PR10MB0676.EURPRD10.PROD.OUTLOOK.COM ([10.167.221.144]) with mapi id 15.01.0549.022; Mon, 1 Aug 2016 22:03:30 +0000 Thread-Topic: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter. Thread-Index: AQHR7BGeDP7O0zstM0iTrQmqbr8ASKA0pclM In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=softfail (sender IP is 10.152.0.58) smtp.mailfrom=hotmail.fr; gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=hotmail.fr; received-spf: SoftFail (protection.outlook.com: domain of transitioning hotmail.fr discourages use of 10.152.0.58 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [bO/LZz0Bap5WDmRtMco0DI91UMwuBAOj] x-eopattributedmessage: 0 x-forefront-antispam-report: CIP:10.152.0.58; IPV:NLI; CTRY:; EFV:NLI; SFV:NSPM; SFS:(10019020)(98900003); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1EUR01HT063; H:AM5PR10MB0676.EURPRD10.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; x-microsoft-exchange-diagnostics: 1; HE1EUR01HT063; 6:QAorv2Pi4DT+6YdBYOG6EiqndEP4Hz85z8D2UvmVTxWtmHBUSkJbzOlFTFIVbfOzenBVcomzYlgVl5rR6Z6ghTn/wx23NBTTbMyKVjWXYEK5FCCTP+Viggo4xnudekd77UmdjWk0U1BZ/wdGnUPuQjv34MPq5/Sv4v3479JdJcyDv4EZh7ogzZ7dbnVy6vbXh9ARQe8brTv6mlr0htWaqMGSyRr7wQw0K7eHJDU4Ugh1k6x8KsypSYI2wC51emVBZOqUogB7JhJgjF1ZS/9FOB07pHLxAxUVICzut69urVzsFwlfK+SUnTs3j5ynC68k; 5:bCw2eoxwu/02g293ZO9lSjhH9Wee1P9eF9rbeMBJmXm4CXUao/kWcAGvhKDmO2Nig0JNMK1Ssnl5AsyAT3BIh4nReUzrGeUxhB+++97C01AL6+muTxf4Kp+2oztKuNIRCLrdzJBOe2NIUB+VWhQjZw==; 24:WuCo7S6XB1BnD+C3LYmUrlK2vEyA1YFFpgytUhKBomtPuQXV4xa3r1i1PeyOQW7X2xGB7aWdbyyBANiLBkBumeU4A4hIRyaSNMbvgwRArrw=; 7:wIJkn6rZw4XCMU/ebZ3/xusblESXVZhSzYCkjx+t0oarcMvxunUxmvT6aCPuKYqUwcI24KOhNrgJxRX/TuhcxRY1j2hELi52HZZXffCiSuCeP1SNI1+08/JvkywU5oWzXbTOLqPa8bQV5zrL2qXNEYgSSQNxmPv0VK8USUFONlnObKuKsMfcQI7AO2FPDeUy9BXV5zLI5kVkUaXY99YEQaltA5K6+fXDFf9W2IuBG6V8irGIDbi7YfuBg x-ms-office365-filtering-correlation-id: f9742998-74f8-49f1-3135-08d3ba57ac13 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(1601124038)(1601125047); SRVR:HE1EUR01HT063; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015012)(82015046); SRVR:HE1EUR01HT063; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR01HT063; x-forefront-prvs: 0021920B5A spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2016 22:03:29.8829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT063 X-OriginalArrivalTime: 01 Aug 2016 22:03:33.0403 (UTC) FILETIME=[8B90A6B0:01D1EC40] X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 65.55.34.212 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206334 Archived-At: --_000_AM5PR10MB0676FA23F7CE8A0AC008998984040AM5PR10MB0676EURP_ Content-Type: text/plain; charset="iso-8859-9" Content-Transfer-Encoding: quoted-printable Dear John, Well, I must admit that I am a naughty boy that has not filed any bug befor= e making this fix. I of course did some basic tests before comitting and it= was OK. The bug description is as follows: Using the ``string within round bracket'' kind of printer definition (round= bracketing meaning left alignment) for a local printers does not work beca= use the ses-local-printer-compile function does not handle this case. IMHO taking this bug fix is not risky and that would make the local printer= feature more complete. The alternative fix would be to document that in th= is release local printers cannot be defined this way, but it seems so simpl= er to fix the lisp than to obfuscate documentation... Vincent. PS : I'll try to join this discussion thread which you mention when I can f= ind it, sorry I have to go to bed now (tired)... ________________________________ De : Emacs-devel de = la part de John Wiegley Envoy=E9 : lundi 1 ao=FBt 2016 18:26:50 =C0 : emacs-devel@gnu.org Cc : Vincent Bela=EFche Objet : Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left a= ligned string formatter. >>>>> "VB" =3D=3D Vincent Bela?che writes= : VB> branch: emacs-25 VB> commit 8a38e948b039516e70176ebe20c5349e2ade6ac5 VB> Author: Vincent Bela=EFche VB> Commit: Vincent Bela=EFche VB> Fix local printer set to left aligned string formatter. VB> * lisp/ses.el (ses-local-printer-compile): Add missing case for VB> left-aligned string formatter. Hello Vincent, Can you please include which bug this is fixing, so that I may verify that = it was indeed on our release blocking list? We're at RC1 now, so any change -= - however small -- requires great scrutiny. Alternatively, please link to the discussion thread where Eli gave the OK t= o commit this to emacs-25. Thanks! -- John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --_000_AM5PR10MB0676FA23F7CE8A0AC008998984040AM5PR10MB0676EURP_ Content-Type: text/html; charset="iso-8859-9" Content-Transfer-Encoding: quoted-printable

Dear John,


Well, I must admit that I am a naughty boy that has not filed any bug be= fore making this fix. I of course did some basic tests before comitting and= it was OK.


The bug description is as follows:


Using the ``string within round bracket'' kind of printer definition (ro= und bracketing meaning left alignment) for a local printers does not work b= ecause the ses-local-printer-compile function does not handle this case.


IMHO taking this bug fix is not risky and that would make the local= printer feature more complete. The alternative fix would be to document th= at in this release local printers cannot be defined this way, but it seems = so simpler to fix the lisp than to obfuscate documentation...


   Vincent.


PS : I'll try to join this discussion thread which you mention when I ca= n find it, sorry I have to go to bed now (tired)...

De : Emacs-devel <emac= s-devel-bounces+vincent.b.1=3Dhotmail.fr@gnu.org> de la part de John= Wiegley <jwiegley@gmail.com>
Envoy=E9 : lundi 1 ao=FBt 2016 18:26:50
=C0 : emacs-devel@gnu.org
Cc : Vincent Bela=EFche
Objet : Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to= left aligned string formatter.
 
>>>>> "VB" =3D=3D Vincent= Bela�che <vincentb1@users.sourceforge.net> writes:

VB> branch: emacs-25
VB> commit 8a38e948b039516e70176ebe20c5349e2ade6ac5
VB> Author: Vincent Bela=EFche <vincentb1@users.sourceforge.net> VB> Commit: Vincent Bela=EFche <vincentb1@users.sourceforge.net>
VB>     Fix local printer set to left aligned string= formatter.

VB>     * lisp/ses.el (ses-local-printer-compile): A= dd missing case for
VB>           &nb= sp;       left-aligned string formatter.

Hello Vincent,

Can you please include which bug this is fixing, so that I may verify that = it
was indeed on our release blocking list?  We're at RC1 now, so any cha= nge --
however small -- requires great scrutiny.

Alternatively, please link to the discussion thread where Eli gave the OK t= o
commit this to emacs-25.

Thanks!
--
John Wiegley          &nb= sp;       GPG fingerprint =3D 4710 CF98 AF9B = 327B B80F
http://newartisans.com  &n= bsp;            = ;           60E1 46C4 BD1= A 7AC1 4BA2

 --_000_AM5PR10MB0676FA23F7CE8A0AC008998984040AM5PR10MB0676EURP_--