From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: psainty@orcon.net.nz, emacs-devel@gnu.org
Subject: Re: Testing redisplay code in batch
Date: Thu, 24 Sep 2020 17:31:05 +0300 [thread overview]
Message-ID: <83zh5ftffa.fsf@gnu.org> (raw)
In-Reply-To: <jwv5z84rt1x.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 23 Sep 2020 19:16:01 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 23 Sep 2020 19:16:01 -0400
> Cc: emacs-devel@gnu.org
>
> This means: with this patch, the xdisp-tests.el succeeds or not in batch
> mode depending on whether the resize_mini_window patch has been applied!
>
> Yay!
>
> WDYT?
Thanks. I have a couple of minor comments:
> + if (FRAME_INITIAL_P (f))
> + paused_p = false; /* No actual display to update! */
I'd appreciate a comment here saying why setting paused_p to false is
the consequence of "no display to update".
> - /* 10 is arbitrary,
> + /* 80/40 is arbitrary,
Why not 80x25? Those are the standard dimensions of old TTYs, so 25
sounds more natural to me than 40.
> @@ -1136,6 +1136,7 @@ make_initial_frame (void)
> init_frame_faces (f);
>
> last_nonminibuf_frame = f;
> + echo_area_window = f->minibuffer_window;
Why is this bit needed?
> - move_it_by_lines (&it, 0);
> + move_it_by_lines (&it, 0); /* bug#43519 */
This is unrelated (and unneeded, IMO).
> @@ -15414,8 +15414,8 @@ redisplay_internal (void)
> /* No redisplay if running in batch mode or frame is not yet fully
> initialized, or redisplay is explicitly turned off by setting
> Vinhibit_redisplay. */
> - if (FRAME_INITIAL_P (SELECTED_FRAME ())
> - || !NILP (Vinhibit_redisplay))
> + if (/* FRAME_INITIAL_P (SELECTED_FRAME ())
> + * || */ !NILP (Vinhibit_redisplay))
> return;
This should be done cleaner, and should also update the commentary.
How about a small NEWS item about this?
next prev parent reply other threads:[~2020-09-24 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 3:56 Testing redisplay code in batch Stefan Monnier
2020-09-23 10:34 ` Phil Sainty
2020-09-23 23:16 ` Stefan Monnier
2020-09-24 14:31 ` Eli Zaretskii [this message]
2020-09-24 18:31 ` Stefan Monnier
2020-09-24 18:58 ` Eli Zaretskii
2020-09-23 10:50 ` Alan Mackenzie
2020-09-23 13:30 ` Stefan Monnier
2020-09-23 14:24 ` Eli Zaretskii
2020-09-23 18:37 ` Stefan Monnier
2020-09-23 18:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zh5ftffa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).