From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: psainty@orcon.net.nz, emacs-devel@gnu.org
Subject: Re: Testing redisplay code in batch
Date: Thu, 24 Sep 2020 21:58:28 +0300 [thread overview]
Message-ID: <83blhvt31n.fsf@gnu.org> (raw)
In-Reply-To: <jwvv9g3m443.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 24 Sep 2020 14:31:58 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: psainty@orcon.net.nz, emacs-devel@gnu.org
> Date: Thu, 24 Sep 2020 14:31:58 -0400
>
> Based on your comments, I assume you consider that this feature is
> acceptable for `master` once it's clean.
Sure, why not? It looks useful.
> /* No actual display to update so the "update" is a nop and
> obviously isn't interrupted by pending input. */
> paused_p = false;
OK.
> Without it I got an assertion failure in xdisp.c:18241
>
> if (MINI_WINDOW_P (w))
> {
> if (w == XWINDOW (echo_area_window)
> && !NILP (echo_area_buffer[0]))
>
> because XWINDOW complains that `echo_area_window` is not a window.
>
> Maybe the better fix is to change `init_xdisp` so it also sets
> `echo_area_window` when `noninteractive`?
Yes, I think so.
> Do you think it's otherwise acceptable as-is? I was thinking of only
> allowing redisplay in `FRAME_INITIAL_P` under the control of some
> special config var.
A command-line option, perhaps? I agree that the "normal" -batch
should probably continue working as it does now.
And yes, I think it's okay to go in. I bet it may not support too
many display features, but we can always extend it as we go.
> > How about a small NEWS item about this?
>
> I'll see to it,
Thanks.
next prev parent reply other threads:[~2020-09-24 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 3:56 Testing redisplay code in batch Stefan Monnier
2020-09-23 10:34 ` Phil Sainty
2020-09-23 23:16 ` Stefan Monnier
2020-09-24 14:31 ` Eli Zaretskii
2020-09-24 18:31 ` Stefan Monnier
2020-09-24 18:58 ` Eli Zaretskii [this message]
2020-09-23 10:50 ` Alan Mackenzie
2020-09-23 13:30 ` Stefan Monnier
2020-09-23 14:24 ` Eli Zaretskii
2020-09-23 18:37 ` Stefan Monnier
2020-09-23 18:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83blhvt31n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).