From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Testing redisplay code in batch Date: Thu, 24 Sep 2020 17:31:05 +0300 Message-ID: <83zh5ftffa.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: psainty@orcon.net.nz, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 24 16:35:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLSLG-0001C3-Nx for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 16:35:26 +0200 Original-Received: from localhost ([::1]:39106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLSLE-0003PA-MH for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 10:35:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLSH7-0000LS-Iq for emacs-devel@gnu.org; Thu, 24 Sep 2020 10:31:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33974) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLSH4-0004aG-Q3; Thu, 24 Sep 2020 10:31:08 -0400 Original-Received: from [176.228.60.248] (port=2191 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLSGv-0002j8-SB; Thu, 24 Sep 2020 10:31:00 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 23 Sep 2020 19:16:01 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256393 Archived-At: > From: Stefan Monnier > Date: Wed, 23 Sep 2020 19:16:01 -0400 > Cc: emacs-devel@gnu.org > > This means: with this patch, the xdisp-tests.el succeeds or not in batch > mode depending on whether the resize_mini_window patch has been applied! > > Yay! > > WDYT? Thanks. I have a couple of minor comments: > + if (FRAME_INITIAL_P (f)) > + paused_p = false; /* No actual display to update! */ I'd appreciate a comment here saying why setting paused_p to false is the consequence of "no display to update". > - /* 10 is arbitrary, > + /* 80/40 is arbitrary, Why not 80x25? Those are the standard dimensions of old TTYs, so 25 sounds more natural to me than 40. > @@ -1136,6 +1136,7 @@ make_initial_frame (void) > init_frame_faces (f); > > last_nonminibuf_frame = f; > + echo_area_window = f->minibuffer_window; Why is this bit needed? > - move_it_by_lines (&it, 0); > + move_it_by_lines (&it, 0); /* bug#43519 */ This is unrelated (and unneeded, IMO). > @@ -15414,8 +15414,8 @@ redisplay_internal (void) > /* No redisplay if running in batch mode or frame is not yet fully > initialized, or redisplay is explicitly turned off by setting > Vinhibit_redisplay. */ > - if (FRAME_INITIAL_P (SELECTED_FRAME ()) > - || !NILP (Vinhibit_redisplay)) > + if (/* FRAME_INITIAL_P (SELECTED_FRAME ()) > + * || */ !NILP (Vinhibit_redisplay)) > return; This should be done cleaner, and should also update the commentary. How about a small NEWS item about this?