unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: modus-themes ELPA and etc/themes
Date: Sun, 21 Mar 2021 07:59:53 +0200	[thread overview]
Message-ID: <83zgyxavxi.fsf@gnu.org> (raw)
In-Reply-To: <jwva6qx36m6.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 20 Mar 2021 16:39:31 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 20 Mar 2021 16:39:31 -0400
> 
> How 'bout moving just `modus-themes.el` (it's a fresh new file, so the
> forensics aspect shouldn't matter that much, especially since the real
> Git history is in the upstream repository rather than in emacs.git
> anyway)?  Part of the reason why `modus-themes.el` could be treated
> differently is that it actually contains a fair bit of ELisp code, so it
> would make sense to compile it.

I envision that more themes will go the way of modus-themes (and at
the time you more or less said the same), so I think it would be good
to design and implement support for such themes in package.el now,
that we have a real-life example.  Otherwise I'm afraid we will have
this discussion many times in the future, and we eventually will end
up with some themes under Lisp and others under etc/themes, which I
think is undesirable.

We recently added some simple infrastructure to support themes that,
like modus-themes, want to dynamically load their parts.  How about
introducing special support for those in package.el as well?

> > Why can't we take any of the other ways to fix this?
> 
> Oh, we definitely can, I'm just trying to figure out which solution is best.

I'd like to keep themes in their current location.  Where this
requires additional infrastructure for themes that do something
special, I think we should add such an infrastructure.

Thanks.



  parent reply	other threads:[~2021-03-21  5:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 19:52 modus-themes ELPA and etc/themes Stefan Monnier
2021-03-20 20:23 ` Eli Zaretskii
2021-03-20 20:39   ` Stefan Monnier
2021-03-20 21:31     ` Basil L. Contovounesios
2021-03-20 22:49       ` Protesilaos Stavrou
2021-03-21  5:59     ` Eli Zaretskii [this message]
2021-03-26 21:41       ` Stefan Monnier
2021-03-27  6:05         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgyxavxi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).