From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: modus-themes ELPA and etc/themes Date: Sun, 21 Mar 2021 07:59:53 +0200 Message-ID: <83zgyxavxi.fsf@gnu.org> References: <8335wpd166.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 21 07:01:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNr9I-000130-4O for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 07:01:16 +0100 Original-Received: from localhost ([::1]:43326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNr9H-0006Sq-4U for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 02:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNr81-00060V-Af for emacs-devel@gnu.org; Sun, 21 Mar 2021 01:59:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35847) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNr80-0002Yw-Fg; Sun, 21 Mar 2021 01:59:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2903 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNr7v-0006BI-VC; Sun, 21 Mar 2021 01:59:52 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 20 Mar 2021 16:39:31 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266682 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 20 Mar 2021 16:39:31 -0400 > > How 'bout moving just `modus-themes.el` (it's a fresh new file, so the > forensics aspect shouldn't matter that much, especially since the real > Git history is in the upstream repository rather than in emacs.git > anyway)? Part of the reason why `modus-themes.el` could be treated > differently is that it actually contains a fair bit of ELisp code, so it > would make sense to compile it. I envision that more themes will go the way of modus-themes (and at the time you more or less said the same), so I think it would be good to design and implement support for such themes in package.el now, that we have a real-life example. Otherwise I'm afraid we will have this discussion many times in the future, and we eventually will end up with some themes under Lisp and others under etc/themes, which I think is undesirable. We recently added some simple infrastructure to support themes that, like modus-themes, want to dynamically load their parts. How about introducing special support for those in package.el as well? > > Why can't we take any of the other ways to fix this? > > Oh, we definitely can, I'm just trying to figure out which solution is best. I'd like to keep themes in their current location. Where this requires additional infrastructure for themes that do something special, I think we should add such an infrastructure. Thanks.