unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: modus-themes ELPA and etc/themes
Date: Sat, 20 Mar 2021 16:39:31 -0400	[thread overview]
Message-ID: <jwva6qx36m6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8335wpd166.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Mar 2021 22:23:45 +0200")

>> The problem is due to the fact that the file is under `etc/themes` and
>> is hence not processed by our autoloads machinery which would otherwise
>> add something like
>> 
>>     (push (purecopy '(modus-themes 1 2 4)) package--builtin-versions)
>> 
>> to lisp/loaddefs.el.
>> 
>> There are various ways to fix this, but to me the simplest would be to
>> move `etc/themes` to `lisp` (or at least to move `modus-themes.el`).
>
> I'd rather we didn't move files around.  If nothing else, it makes
> forensics harder down the line.  Besides, we had themes in that place
> for too long to make such changes now, and for this minor reason on
> top of that.

OK, so it's a definite no for moving `etc/themes`.

How 'bout moving just `modus-themes.el` (it's a fresh new file, so the
forensics aspect shouldn't matter that much, especially since the real
Git history is in the upstream repository rather than in emacs.git
anyway)?  Part of the reason why `modus-themes.el` could be treated
differently is that it actually contains a fair bit of ELisp code, so it
would make sense to compile it.

> Why can't we take any of the other ways to fix this?

Oh, we definitely can, I'm just trying to figure out which solution is best.


        Stefan




  reply	other threads:[~2021-03-20 20:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 19:52 modus-themes ELPA and etc/themes Stefan Monnier
2021-03-20 20:23 ` Eli Zaretskii
2021-03-20 20:39   ` Stefan Monnier [this message]
2021-03-20 21:31     ` Basil L. Contovounesios
2021-03-20 22:49       ` Protesilaos Stavrou
2021-03-21  5:59     ` Eli Zaretskii
2021-03-26 21:41       ` Stefan Monnier
2021-03-27  6:05         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6qx36m6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).