From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues
Date: Mon, 12 Jun 2023 20:51:27 +0300 [thread overview]
Message-ID: <83zg54wov4.fsf@gnu.org> (raw)
In-Reply-To: <87fs6whaj9.fsf@gmail.com> (message from Robert Pluim on Mon, 12 Jun 2023 19:10:02 +0200)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
> Date: Mon, 12 Jun 2023 19:10:02 +0200
>
> >>>>> On Mon, 12 Jun 2023 19:40:24 +0300, Eli Zaretskii <eliz@gnu.org> said:
>
> Eli> Fine by me, please install.
>
> Done, although we should consider having that action have
> '(inhibit-same-window . t)' in it. Maybe on master.
Definitely on master.
> >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
> >> +(defcustom display-tex-shell-buffer-action display-buffer--in-previous-window-action
> >> "`display-buffer' action for displaying TeX shell buffers."
> >> :type display-buffer--action-custom-type
> >> :risky t
>
> Eli> Why do we need an extra variable here?
>
> We donʼt, it just looks nicer than stuffing a multi-line constant in
> the default value field.
I guess "nicer" is in the eyes of the beholder. To me, it just makes
the whole arrangement harder to read and understand.
prev parent reply other threads:[~2023-06-12 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org>
[not found] ` <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org>
2023-06-12 12:21 ` emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Michael Albinus
2023-06-12 13:11 ` Eli Zaretskii
2023-06-12 13:25 ` Eli Zaretskii
2023-06-12 14:01 ` Robert Pluim
2023-06-12 14:35 ` Eli Zaretskii
2023-06-12 15:57 ` Robert Pluim
2023-06-12 16:40 ` Eli Zaretskii
2023-06-12 17:10 ` Robert Pluim
2023-06-12 17:51 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zg54wov4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).