From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues
Date: Mon, 12 Jun 2023 16:01:46 +0200 [thread overview]
Message-ID: <87sfawhj91.fsf@gmail.com> (raw)
In-Reply-To: <83edmgygew.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2023 16:11:03 +0300")
>>>>> On Mon, 12 Jun 2023 16:11:03 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: Eli Zaretskii <eliz@gnu.org>
>> Date: Mon, 12 Jun 2023 14:21:07 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> Hi Eli,
>>
>> > branch: emacs-29
>> > commit bdb0bc2b4e44a7d40369e10e3de825d58fe46825
>> > Author: Eli Zaretskii <eliz@gnu.org>
>> > Commit: Eli Zaretskii <eliz@gnu.org>
>> >
>> > Fix tex-mode display-buffer issues
>> >
>> > * lisp/window.el (display-tex-shell-buffer-action): New defcustom.
>>
>> This results in a test error:
>>
>> --8<---------------cut here---------------start------------->8---
>> # make -C test test-custom-opts
>> ...
>> The following options might have problems:
>> variable: display-tex-shell-buffer-action
>> value: display-buffer-in-previous-window
>> type: (cons :tag "Action" (choice :tag "Action functions" (choice :tag "Function" (const :tag "--" ignore) (const display-buffer-reuse-window) (const display-buffer-pop-up-window) (const display-buffer-same-window) (const display-buffer-pop-up-frame) (const display-buffer-full-frame) (const display-buffer-in-child-frame) (const display-buffer-below-selected) (const display-buffer-at-bottom) (const display-buffer-in-previous-window) (const display-buffer-use-least-recent-window) (const display-buffer-use-some-window) (const display-buffer-use-some-frame) (function :tag "Other function")) (repeat :tag "List of functions" (choice :tag "Function" (const :tag "--" ignore) (const display-buffer-reuse-window) (const display-buffer-pop-up-window) (const display-buffer-same-window) (const display-buffer-pop-up-frame) (const display-buffer-full-frame) (const display-buffer-in-child-frame) (const display-buffer-below-selected) (const display-buffer-at-bottom) (const display-buffer-in-previous-window) (const display-buffer-use-least-recent-window) (const display-buffer-use-some-window) (const display-buffer-use-some-frame) (function :tag "Other function")))) (alist :tag "Action arguments" :key-type symbol :value-type (sexp :tag "Value")))
>> --8<---------------cut here---------------end--------------->8---
Eli> Sorry, I have no idea what this failure means. In particular, the
Eli> value is correct for the defcustom, and works in practice, and also
Eli> fits the type of the defcustom (AFAICT).
Are you sure?
(defconst display-buffer--action-custom-type
`(cons :tag "Action"
(choice :tag "Action functions"
,display-buffer--action-function-custom-type
(repeat
:tag "List of functions"
,display-buffer--action-function-custom-type))
(alist :tag "Action arguments"
:key-type symbol
:value-type (sexp :tag "Value")))
"Custom type for `display-buffer' actions.")
(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
"`display-buffer' action for displaying TeX shell buffers."
:type display-buffer--action-custom-type
Did you mean this instead:
(defconst display-buffer--action-function-custom-type
'(choice :tag "Function"
(const :tag "--" ignore) ; default for insertion
(const display-buffer-reuse-window)
Robert
--
next prev parent reply other threads:[~2023-06-12 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org>
[not found] ` <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org>
2023-06-12 12:21 ` emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Michael Albinus
2023-06-12 13:11 ` Eli Zaretskii
2023-06-12 13:25 ` Eli Zaretskii
2023-06-12 14:01 ` Robert Pluim [this message]
2023-06-12 14:35 ` Eli Zaretskii
2023-06-12 15:57 ` Robert Pluim
2023-06-12 16:40 ` Eli Zaretskii
2023-06-12 17:10 ` Robert Pluim
2023-06-12 17:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfawhj91.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).