From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 20:51:27 +0300 Message-ID: <83zg54wov4.fsf@gnu.org> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> <87sfawhj91.fsf@gmail.com> <83a5x4yci0.fsf@gnu.org> <87o7lkhdwz.fsf@gmail.com> <83352wy6pz.fsf@gnu.org> <87fs6whaj9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 19:51:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8lhv-0001G5-4p for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 19:51:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8lhE-0006Fy-Ur; Mon, 12 Jun 2023 13:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8lhA-0006DO-I8 for emacs-devel@gnu.org; Mon, 12 Jun 2023 13:51:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8lhA-0002VR-7O; Mon, 12 Jun 2023 13:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7T1TJrITInaIKxSWHa/mKobRjU/8O+4uwq5rf1+icX0=; b=DzjHN4N/b3ZYvN3bf+5A SlIvP+UPNz2GCEyRveC1gcZn59bct5pMUPqjmWbyVzqcHSbsNfxf4lOJ1h3A240OHbu51a9NZIfBz j/yLruIJPEo6J2M3vealVrA/WZ8Z3GZ/PFeuH4Gt+nLUxT94CWmnQplZeMIR4TNve8BdsNSAT8PiV AQ9LN8QVzJdX0H000zzXtl0lH6zDQTXgJRTfYRLlRY/LzR+ItHLMR9YK8OIdes6u0mNPLwyBzbUQC T929JPH5SlsuaHMP5KsHiUjBTeEjMUh5iGo3sAmgx94u3MlCybo+VhTIYCgazLEUBKeQb4Qk+odPa 2AY9+tGvsonTog==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8lh9-0000hd-Ka; Mon, 12 Jun 2023 13:51:12 -0400 In-Reply-To: <87fs6whaj9.fsf@gmail.com> (message from Robert Pluim on Mon, 12 Jun 2023 19:10:02 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306757 Archived-At: > From: Robert Pluim > Cc: michael.albinus@gmx.de, emacs-devel@gnu.org > Date: Mon, 12 Jun 2023 19:10:02 +0200 > > >>>>> On Mon, 12 Jun 2023 19:40:24 +0300, Eli Zaretskii said: > > Eli> Fine by me, please install. > > Done, although we should consider having that action have > '(inhibit-same-window . t)' in it. Maybe on master. Definitely on master. > >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window > >> +(defcustom display-tex-shell-buffer-action display-buffer--in-previous-window-action > >> "`display-buffer' action for displaying TeX shell buffers." > >> :type display-buffer--action-custom-type > >> :risky t > > Eli> Why do we need an extra variable here? > > We donʼt, it just looks nicer than stuffing a multi-line constant in > the default value field. I guess "nicer" is in the eyes of the beholder. To me, it just makes the whole arrangement harder to read and understand.