From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org, rms@gnu.org, xenodasein@tutanota.de,
pappasbrent@knights.ucf.edu
Subject: Re: Thoughts on replacing macros with static inline functions
Date: Fri, 18 Nov 2022 10:34:55 +0200 [thread overview]
Message-ID: <83wn7sbqz4.fsf@gnu.org> (raw)
In-Reply-To: <87leo8eq0y.fsf@yahoo.com> (message from Po Lu on Fri, 18 Nov 2022 14:27:09 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: Richard Stallman <rms@gnu.org>, xenodasein@tutanota.de, Eli Zaretskii
> <eliz@gnu.org>, pappasbrent@knights.ucf.edu
> Date: Fri, 18 Nov 2022 14:27:09 +0800
>
> And how is an additional function an improvement over extremely trivial
> macros, like these:
>
> #define XM_DRAG_REASON(originator, code) ((code) | ((originator) << 7))
> #define XM_DRAG_REASON_ORIGINATOR(reason) (((reason) & 0x80) ? 1 : 0)
> #define XM_DRAG_REASON_CODE(reason) ((reason) & 0x7f)
The purpose of macros such as the above is to explain the meaning of
the code in human-readable terms. Replacing this by functions makes
no more sense than replacing "c = a + b;" with a function.
next prev parent reply other threads:[~2022-11-18 8:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 18:05 Thoughts on replacing macros with static inline functions Brent Pappas
2022-11-15 12:45 ` Eli Zaretskii
2022-11-18 5:05 ` Richard Stallman
2022-11-18 6:19 ` xenodasein--- via Emacs development discussions.
2022-11-18 6:27 ` Po Lu
2022-11-18 6:32 ` xenodasein--- via Emacs development discussions.
2022-11-18 7:29 ` Po Lu
2022-11-18 8:34 ` Eli Zaretskii [this message]
2022-11-18 11:31 ` xenodasein--- via Emacs development discussions.
2022-11-18 11:43 ` Po Lu
2022-11-18 12:00 ` Eli Zaretskii
2022-11-18 6:59 ` tomas
2022-11-18 7:12 ` xenodasein--- via Emacs development discussions.
2022-11-18 14:53 ` Stefan Monnier
2022-11-18 16:16 ` Dr. Arne Babenhauserheide
2022-11-15 13:49 ` Po Lu
2022-11-15 15:54 ` xenodasein--- via Emacs development discussions.
2022-11-15 14:10 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn7sbqz4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=pappasbrent@knights.ucf.edu \
--cc=rms@gnu.org \
--cc=xenodasein@tutanota.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).