Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Stefan Kangas]

Mattias Engdegård <mattiase@acm.org> writes:

> +(defun flymake-tests--gcc-is-clang ()
> +  "Whether the `gcc' command actually runs the Clang compiler."
> +  (string-match "[Cc]lang version "
> +                (shell-command-to-string "gcc --version")))

We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el

  (let ((semantic-gcc-test-strings (list (semantic-gcc-query "gcc" "-v"))))
    ;; Some macOS machines run llvm when you type gcc.  (!)
    ;; We can't even check if it's a symlink; it's a binary placed in
    ;; "/usr/bin/gcc".  So check the output and just skip this test if
    ;; it looks like that's the case.
    (unless (string-match "Apple \\(LLVM\\|clang\\)\\|Xcode\\.app"
                          (car semantic-gcc-test-strings))
        ...))

Should these tests perhaps be consolidated somehow?

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Mattias Engdegård]

2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>:

> We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el

> Should these tests perhaps be consolidated somehow?

Maybe, or at least be written identically. I don't know if there is a suitable place to put an auxiliary function like this.

More importantly, both should probably use the same detection pattern. Do the flymake tests fail on Monterey?

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Stefan Kangas]

Mattias Engdegård <mattiase@acm.org> writes:

> 2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>:
>
>> We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el
>
>> Should these tests perhaps be consolidated somehow?
>
> Maybe, or at least be written identically. I don't know if there is a
> suitable place to put an auxiliary function like this.

subr-x.el, perhaps?

> More importantly, both should probably use the same detection
> pattern. Do the flymake tests fail on Monterey?

I don't use Monterey, so I can't check.

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Eli Zaretskii]

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Sun, 2 Jan 2022 17:30:53 +0100
> Cc: emacs-devel@gnu.org
> 
> 2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>:
> 
> > We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el
> 
> > Should these tests perhaps be consolidated somehow?
> 
> Maybe, or at least be written identically. I don't know if there is a suitable place to put an auxiliary function like this.

subr.el, probably.

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Stefan Kangas]

Stefan Kangas <stefankangas@gmail.com> writes:

> subr-x.el, perhaps?

Sorry, I meant ert-x.el.

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Stefan Monnier]

Eli Zaretskii [2022-01-02 20:12:31] wrote:
>> Maybe, or at least be written identically. I don't know if there is
>> a suitable place to put an auxiliary function like this.
> subr.el, probably.

That would mean the function is preloaded, whereas we're talking here
about code that's only used in our test suite, which doesn't seem to
justify preloading it.


        Stefan

Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Mattias Engdegård <mattiase@acm.org>,
>   stefan@marxist.se,
>   emacs-devel@gnu.org
> Date: Sun, 02 Jan 2022 14:04:18 -0500
> 
> Eli Zaretskii [2022-01-02 20:12:31] wrote:
> >> Maybe, or at least be written identically. I don't know if there is
> >> a suitable place to put an auxiliary function like this.
> > subr.el, probably.
> 
> That would mean the function is preloaded, whereas we're talking here
> about code that's only used in our test suite, which doesn't seem to
> justify preloading it.

I envision the need to make these checks not just in the test suite.